Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,16 @@ jobs:
ABI=$(node -p "process.versions.modules")
./scripts/windows-bundle-runtime.sh "lib/binding/node-v${ABI}-win32-x64"

# `node-gtk bundle` end-to-end: bundle a smoke app against this checkout
# (inside the MINGW64 environment), then run the produced .cmd launcher.
# Deliberately after the prebuilt step: the binding dir then carries the
# self-contained runtime, exercising the bundler's trim of it. One node
# version suffices (the bundler is ABI-generic JS). The runner session
# has a desktop, so no virtual display is needed.
- name: Bundle smoke test
if: matrix.node == 24
run: node scripts/bundle-smoke-test.js

# Publish the prebuilt to S3 on a `[publish binary]` commit, like the
# Linux/macOS jobs do via scripts/ci.sh.
- name: Publish prebuilt
Expand Down Expand Up @@ -147,13 +157,17 @@ jobs:
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

# `node-gtk bundle` end-to-end: bundle a smoke app against this checkout,
# then run the produced launcher. Linux-only for now; one node version
# suffices (the bundler is ABI-generic JS, tested against the matrix's
# addon build anyway).
# then run the produced launcher. One node version suffices (the bundler
# is ABI-generic JS, tested against the matrix's addon build anyway).
# Linux needs a virtual display; the macOS runner has a window server.
- name: Bundle smoke test
if: matrix.os == 'ubuntu-latest' && matrix.node == 24
run: xvfb-run -a node scripts/bundle-smoke-test.js

- name: Bundle smoke test (macOS)
if: matrix.os == 'macos-latest' && matrix.node == 24
run: node scripts/bundle-smoke-test.js

# `node-gtk flatpak` generation: manifest + offline sources must be
# complete and buildable. The full sandbox build is not run per-CI-run
# (it downloads the ~1GB GNOME SDK); this check needs no flatpak at all.
Expand Down
164 changes: 0 additions & 164 deletions HANDOFF.md

This file was deleted.

4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ npx node-gtk create <your-app>
Also see our [hello world](./examples/hello-world.mjs), [web browser](./examples/browser.mjs)
or [system monitor](./examples/system-monitor.mjs) examples.

When it's time to ship (Linux for now — see [doc/bundling.md](./doc/bundling.md)):
When it's time to ship (see [doc/bundling.md](./doc/bundling.md)):

```sh
npx node-gtk flatpak # a Flatpak users install with one click (Flathub-ready)
npx node-gtk bundle # a self-contained portable directory / tar.gz
npx node-gtk bundle # self-contained portable app: Linux, macOS and Windows
```

## Installing
Expand Down
Loading
Loading