Skip to content

Improve error handling for missing RomM platform after upgrade#122

Merged
gantoine merged 1 commit into
mainfrom
posthog-code/fix-game-install-error-after-upgrade-to-version-0-6-0-7
Jul 4, 2026
Merged

Improve error handling for missing RomM platform after upgrade#122
gantoine merged 1 commit into
mainfrom
posthog-code/fix-game-install-error-after-upgrade-to-version-0-6-0-7

Conversation

@gantoine

@gantoine gantoine commented Jul 4, 2026

Copy link
Copy Markdown
Member

TL;DR

Added a clearer, actionable error message when users encounter missing RomM platform mappings after upgrading from pre-0.6 versions, replacing cryptic "-1 not found" errors with helpful guidance on how to reconfigure their settings.

What changed?

  • Split platform validation into two separate checks with distinct error handling:

    • Unconfigured emulator/profile mappings now fail silently (existing behavior)
    • Missing RomM platform selection now triggers a user-facing notification with actionable instructions
  • Enhanced the missing platform detection to check both RomMPlatformId <= 0 and RomMPlatform nullability, covering both unset mappings (-1) and empty defaults (0)

  • Added a user-friendly error notification that:

    • Uses the mapping name or emulator name for clarity
    • Generates stable notification IDs per mapping to prevent duplicate notifications on repeated imports
    • Explains that this commonly occurs after plugin upgrades
    • Provides step-by-step instructions to resolve the issue
  • Improved code comments explaining the upgrade migration scenario and why special handling is needed


Created with PostHog Code

@gantoine
gantoine merged commit 40ad165 into main Jul 4, 2026
5 checks passed
@gantoine
gantoine deleted the posthog-code/fix-game-install-error-after-upgrade-to-version-0-6-0-7 branch July 4, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant