Improve error handling for missing RomM platform after upgrade#122
Merged
gantoine merged 1 commit intoJul 4, 2026
Merged
Conversation
gantoine
deleted the
posthog-code/fix-game-install-error-after-upgrade-to-version-0-6-0-7
branch
July 4, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a clearer, actionable error message when users encounter missing RomM platform mappings after upgrading from pre-0.6 versions, replacing cryptic "-1 not found" errors with helpful guidance on how to reconfigure their settings.
What changed?
Split platform validation into two separate checks with distinct error handling:
Enhanced the missing platform detection to check both
RomMPlatformId <= 0andRomMPlatformnullability, covering both unset mappings (-1) and empty defaults (0)Added a user-friendly error notification that:
Improved code comments explaining the upgrade migration scenario and why special handling is needed
Created with PostHog Code