fix: prevent QR login code from overflowing settings layout#123
Merged
Conversation
The QR code was rendered as an absolutely-positioned Border overlaid on the credentials grid with Panel.ZIndex=9999 and a Height bound to its own ActualWidth. Because the spanned grid rows are Auto-height, the square QR painted on top of the sections below it (Emulator path mappings, Open in Browser), causing the visible overflow. Restructure the auth section into a clean two-region layout: credential fields on the left, and a QR panel on the right that lives in the normal layout flow at a fixed 200x200 size. It now pushes surrounding content instead of overlapping it. Toggle the single QRPanel container instead of flipping the overlay borders. Generated-By: PostHog Code Task-Id: a8c7cfad-1c69-421e-9d5e-d27c87126fcf
Contributor
Greptile SummaryThis PR moves QR login into the normal settings layout. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix: prevent QR login code from overflow..." | Re-trigger Greptile |
Move the QR section out of the right-hand column (where the button label was clipped by the window edge) to a vertical stack directly below the credential fields. Button on top, QR code, then the browser/timer row, all left-aligned and in the normal layout flow. Generated-By: PostHog Code Task-Id: a8c7cfad-1c69-421e-9d5e-d27c87126fcf
greptile-apps
Bot
dismissed
their stale review
July 10, 2026 02:23
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When clicking Login via QR Code, the QR content overflowed the settings layout and overlapped the sections below it (Emulator path mappings, Open in Browser).
The QR was rendered as an absolutely-positioned
Borderoverlaid on the credentials grid withPanel.ZIndex="9999"and aHeightbound to its ownActualWidthto force a square. Because the spanned grid rows areAuto-height (short), the square QR painted on top of everything below it instead of reserving space — the visible overflow.Fix
Restructured the Authentication section into a clean two-region layout:
The QR now pushes surrounding content down instead of drawing over it. Removed the
Panel.ZIndex="9999"overlay hack and the unboundedHeight="{Binding ActualWidth}"self-binding. Code-behind toggles a singleQRPanelcontainer (Visible/Collapsed) rather than flipping the two overlay borders.Testing
Changes are layout-only and element names line up between XAML and code-behind. This machine has no .NET toolchain (Windows/Playnite plugin), so a build + visual check on Windows is recommended to confirm the 200px sizing looks right (easy to bump if preferred larger/smaller).
Created with PostHog Code