Skip to content

fix: prevent QR login code from overflowing settings layout#123

Merged
gantoine merged 2 commits into
mainfrom
posthog-code/fix-qr-login-overflow
Jul 10, 2026
Merged

fix: prevent QR login code from overflowing settings layout#123
gantoine merged 2 commits into
mainfrom
posthog-code/fix-qr-login-overflow

Conversation

@gantoine

Copy link
Copy Markdown
Member

Problem

When clicking Login via QR Code, the QR content overflowed the settings layout and overlapped the sections below it (Emulator path mappings, Open in Browser).

The QR was rendered as an absolutely-positioned Border overlaid on the credentials grid with Panel.ZIndex="9999" and a Height bound to its own ActualWidth to force a square. Because the spanned grid rows are Auto-height (short), the square QR painted on top of everything below it instead of reserving space — the visible overflow.

Before
QR square overlaps Emulator path mappings and the Open in Browser button

Fix

Restructured the Authentication section into a clean two-region layout:

  • Left — credential fields (host, token, basic auth, username, password), unchanged in appearance.
  • Right — a QR panel (button → QR image → Open in Browser + timer) that lives in the normal layout flow at a fixed 200×200 size.

The QR now pushes surrounding content down instead of drawing over it. Removed the Panel.ZIndex="9999" overlay hack and the unbounded Height="{Binding ActualWidth}" self-binding. Code-behind toggles a single QRPanel container (Visible/Collapsed) rather than flipping the two overlay borders.

Testing

Changes are layout-only and element names line up between XAML and code-behind. This machine has no .NET toolchain (Windows/Playnite plugin), so a build + visual check on Windows is recommended to confirm the 200px sizing looks right (easy to bump if preferred larger/smaller).


Created with PostHog Code

The QR code was rendered as an absolutely-positioned Border overlaid on
the credentials grid with Panel.ZIndex=9999 and a Height bound to its own
ActualWidth. Because the spanned grid rows are Auto-height, the square QR
painted on top of the sections below it (Emulator path mappings, Open in
Browser), causing the visible overflow.

Restructure the auth section into a clean two-region layout: credential
fields on the left, and a QR panel on the right that lives in the normal
layout flow at a fixed 200x200 size. It now pushes surrounding content
instead of overlapping it. Toggle the single QRPanel container instead of
flipping the overlay borders.

Generated-By: PostHog Code
Task-Id: a8c7cfad-1c69-421e-9d5e-d27c87126fcf
@greptile-apps

greptile-apps Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR moves QR login into the normal settings layout. The main changes are:

  • Split authentication settings into credential and QR regions.
  • Replaced the high-z QR overlay with a fixed 200×200 panel.
  • Updated code-behind to show and collapse the QR panel container.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
Settings/SettingsView.xaml Restructures the authentication layout so the QR code panel sits beside credentials and participates in normal layout flow.
Settings/SettingsView.xaml.cs Updates the QR login visibility lifecycle to toggle the new QR panel container and collapse details on cleanup.

Reviews (1): Last reviewed commit: "fix: prevent QR login code from overflow..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot previously approved these changes Jul 10, 2026
Move the QR section out of the right-hand column (where the button label
was clipped by the window edge) to a vertical stack directly below the
credential fields. Button on top, QR code, then the browser/timer row,
all left-aligned and in the normal layout flow.

Generated-By: PostHog Code
Task-Id: a8c7cfad-1c69-421e-9d5e-d27c87126fcf
@greptile-apps
greptile-apps Bot dismissed their stale review July 10, 2026 02:23

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

@gantoine
gantoine merged commit 73b81f2 into main Jul 10, 2026
5 checks passed
@gantoine
gantoine deleted the posthog-code/fix-qr-login-overflow branch July 10, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant