[cli] Fix Nativewind home layout and rerun-hint quoting#611
Closed
danstepanov wants to merge 2 commits into
Closed
[cli] Fix Nativewind home layout and rerun-hint quoting#611danstepanov wants to merge 2 commits into
danstepanov wants to merge 2 commits into
Conversation
ScreenContent centers its children, so EditScreenInfo's unconstrained outer View sized to the text's intrinsic single-line width and the description clipped at the screen edge. Give it w-full so the text wraps within the screen. The stack home button wrapper only had safe-area padding, which is zero horizontally on iPhones, so the button touched the screen edges. Add px-6.
quoteShellArg wrapped every project name in quotes, so the 'To recreate this project' hint showed npx rn-new@latest 'my-app' even for names that need no quoting. Return safe-charset values unchanged and keep quoting for names with spaces or other special characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three small fixes for issues spotted while testing generated apps:
ScreenContentcenters its children (items-center), soEditScreenInfo's unconstrained outerViewsized itself to the text's intrinsic single-line width and the description clipped at the screen edge ("Change any of the text, save the file, and…"). Give the outerVieww-fullso the text wraps within the screen.px-6.npx rn-new@latest 'my-app'even for names that need no quoting.quoteShellArgnow returns safe-charset values unchanged and only quotes names with spaces or other special characters.Related Issue
N/A — spotted during manual testing of generated apps.
Motivation and Context
Fresh
--nativewind --expo-routerprojects had visibly broken layout on first launch.How Has This Been Tested?
bun run build(tsc + ejslint) passes--nativewind --expo-routerprojects and verified the new classes land in the output and the project typechecks (tsc --noEmitexit 0)quotetestunquoted and'quote test'quotedScreenshots (if appropriate):
Before: button spans the full screen width; description text ends mid-sentence at the screen edge.
Generated by Claude Code