Skip to content

Add tests for Real32Quant#45

Merged
silverweed merged 1 commit intoroot-project:mainfrom
silverweed:real32quant
May 30, 2025
Merged

Add tests for Real32Quant#45
silverweed merged 1 commit intoroot-project:mainfrom
silverweed:real32quant

Conversation

@silverweed
Copy link
Copy Markdown
Contributor

Closes #6

@silverweed silverweed requested review from enirolf and hahnjo May 2, 2025 06:59
@silverweed silverweed self-assigned this May 2, 2025
@hahnjo hahnjo added the types label May 2, 2025
@hahnjo hahnjo added this to the 1.0 milestone May 2, 2025
@hahnjo hahnjo requested a review from pcanal May 5, 2025 09:34
Comment thread types/fundamental/real32quant/README.md Outdated
Comment thread types/fundamental/real32quant/README.md Outdated
Comment thread types/fundamental/real32quant/README.md Outdated
Comment thread types/fundamental/real32quant/README.md Outdated
Comment thread types/fundamental/real32quant/README.md Outdated
Comment thread types/fundamental/real32quant/write.C Outdated
@silverweed silverweed changed the title Add Real32Quant Add tests for Real32Quant May 5, 2025
hahnjo
hahnjo previously requested changes May 6, 2025
Comment thread types/fundamental/real32quant/write.C Outdated
Comment thread types/fundamental/real32quant/write.C Outdated
Comment thread types/fundamental/real32quant/README.md
Comment thread types/fundamental/real32quant/write.C Outdated
Comment thread types/fundamental/real32quant/write.C Outdated
Comment thread types/fundamental/real32quant/write.C Outdated
Comment thread types/fundamental/real32quant/write.C Outdated
@silverweed silverweed requested a review from hahnjo May 14, 2025 12:48
@hahnjo hahnjo requested review from hahnjo and removed request for hahnjo May 15, 2025 14:52
@hahnjo hahnjo dismissed their stale review May 15, 2025 14:53

comments addressed

Copy link
Copy Markdown
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silverweed silverweed merged commit 63d9408 into root-project:main May 30, 2025
1 check passed
@silverweed silverweed deleted the real32quant branch May 30, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test for Real32Quant column type

2 participants