[core] deprecate TROOT::GetListOfSecContexts()

Author: jblomer

core/base/inc/TROOT.h

@@ -99,10 +99,15 @@ namespace ROOT {
    UInt_t GetThreadPoolSize();
 }
 
+namespace ROOT::Deprecated::Internal {
+TSeqCollection *GetListOfSecContexts(const TROOT &);
+} // namespace ROOT::Deprecated::Internal
+
 class TROOT : public TDirectory {
 
 friend class TCling;
 friend TROOT *ROOT::Internal::GetROOT2();
+friend TSeqCollection *ROOT::Deprecated::Internal::GetListOfSecContexts(const TROOT &);
 
 private:
    Int_t           fLineIsProcessing = 0;   ///< To synchronize multi-threads
@@ -256,7 +261,9 @@ friend TROOT *ROOT::Internal::GetROOT2();
    TSeqCollection   *GetListOfStreamerInfo() const { return fStreamerInfo; }
    TSeqCollection   *GetListOfMessageHandlers() const { return fMessageHandlers; }
    TCollection      *GetListOfClassGenerators() const { return fClassGenerators; }
-   TSeqCollection   *GetListOfSecContexts() const { return fSecContexts; }
+   TSeqCollection   *GetListOfSecContexts() const
+      R__DEPRECATED(6, 42, "GetListOfSecContexts authentication is deprecated")
+      { return ROOT::Deprecated::Internal::GetListOfSecContexts(*this); }
    TSeqCollection   *GetClipboard() const { return fClipboard; }
    TSeqCollection   *GetListOfDataSets() const { return fDataSets; }
    TCollection      *GetListOfEnums(Bool_t load = kFALSE);

core/base/src/TROOT.cxx

@@ -170,6 +170,11 @@ FARPROC dlsym(void *library, const char *function_name)
 #include "TWinNTSystem.h"
 #endif
 
+TSeqCollection *ROOT::Deprecated::Internal::GetListOfSecContexts(const TROOT &r)
+{
+   return r.fSecContexts;
+}
+
 extern "C" void R__SetZipMode(int);
 
 static DestroyInterpreter_t *gDestroyInterpreter = nullptr;
@@ -2835,7 +2840,7 @@ void TROOT::SetBatch(Bool_t batch)
 ///    interactive mode.
 ///  - "server:port": turns the web display into server mode with specified port. Web widgets will not be displayed,
 ///    only text message with window URL will be printed on standard output
-///  
+///
 /// \note See more details related to webdisplay on RWebWindowsManager::ShowWindow
 
 void TROOT::SetWebDisplay(const char *webdisplay)

net/auth/src/TAuthenticate.cxx

@@ -2151,7 +2151,7 @@ void ROOT::Deprecated::TAuthenticate::Show(Option_t *opt)
    if (sopt.Contains("s", TString::kIgnoreCase)) {
 
       // Print established security contexts
-      TIter next(gROOT->GetListOfSecContexts());
+      TIter next(ROOT::Deprecated::Internal::GetListOfSecContexts(*gROOT));
       TSecContext *sc = 0;
       while ((sc = (TSecContext *)next()))
          sc->Print();
@@ -2207,7 +2207,7 @@ Int_t ROOT::Deprecated::TAuthenticate::AuthExists(TString username, Int_t method
 
    // If nothing found, try the all list
    if (!secctx) {
-      next = TIter(gROOT->GetListOfSecContexts());
+      next = TIter(ROOT::Deprecated::Internal::GetListOfSecContexts(*gROOT));
       while ((secctx = (TRootSecContext *)next())) {
          if (secctx->GetMethod() == method) {
             if (fRemote == secctx->GetHost()) {

net/auth/src/TRootSecContext.cxx

@@ -93,7 +93,7 @@ void ROOT::Deprecated::TRootSecContext::DeActivate(Option_t *Opt)
    if (remove && fOffSet > -1){
       R__LOCKGUARD(gROOTMutex);
       // Remove from the global list
-      gROOT->GetListOfSecContexts()->Remove(this);
+      ROOT::Deprecated::Internal::GetListOfSecContexts(*gROOT)->Remove(this);
       // Remove also from local lists in THostAuth objects
       TAuthenticate::RemoveSecContext(this);
    }

net/net/src/TSecContext.cxx

@@ -65,7 +65,7 @@ ROOT::Deprecated::TSecContext::TSecContext(const char *user, const char *host, I
    // Keep official list updated with active TSecContexts
    if (fOffSet > -1) {
       R__LOCKGUARD(gROOTMutex);
-      gROOT->GetListOfSecContexts()->Add(this);
+      ROOT::Deprecated::Internal::GetListOfSecContexts(*gROOT)->Add(this);
    }
 }
 
@@ -101,7 +101,7 @@ ROOT::Deprecated::TSecContext::TSecContext(const char *url, Int_t meth, Int_t of
    // Keep official list updated with active TSecContexts
    if (fOffSet > -1) {
       R__LOCKGUARD(gROOTMutex);
-      gROOT->GetListOfSecContexts()->Add(this);
+      ROOT::Deprecated::Internal::GetListOfSecContexts(*gROOT)->Add(this);
    }
 }
 
@@ -161,7 +161,7 @@ void ROOT::Deprecated::TSecContext::Cleanup()
       CleanupSecContext(kTRUE);
       DeActivate("R");
       // All have been remotely Deactivated
-      TIter nxtl(gROOT->GetListOfSecContexts());
+      TIter nxtl(ROOT::Deprecated::Internal::GetListOfSecContexts(*gROOT));
       TSecContext *nscl;
       while ((nscl = (TSecContext *)nxtl())) {
          if (nscl != this && !strcmp(nscl->GetHost(), fHost.Data())) {
@@ -198,7 +198,7 @@ void ROOT::Deprecated::TSecContext::DeActivate(Option_t *Opt)
    if (remove && fOffSet > -1){
       R__LOCKGUARD(gROOTMutex);
       // Remove from the global list
-      gROOT->GetListOfSecContexts()->Remove(this);
+      ROOT::Deprecated::Internal::GetListOfSecContexts(*gROOT)->Remove(this);
    }
 
    // Set inactive