Skip to content

Commit 1d1e0ee

Browse files
committed
[RF][RS] Remove unused DebuggingSampler and DebuggingTestStat classes
These were mock implementations of the TestStatSampler and TestStatistic interfaces that returned uniform random numbers independent of the data. They were only meant for debugging the RooStats framework itself during its initial development and are referenced nowhere else in the codebase, tutorials, or tests. They were also never fully functional: DebuggingSampler's GetTestStatistic() only prints "IS NOT IMPLEMENTED" and returns a nullptr, and DebuggingTestStat leaks its data members because it lacks a destructor.
1 parent 0c30dfd commit 1d1e0ee

5 files changed

Lines changed: 1 addition & 184 deletions

File tree

README/ReleaseNotes/v642/index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ The following people have contributed to this new version:
5151
* The conversion from Python set to **RooArgSet** is deprecated and won't work anymore in ROOT 6.44. The problem is that Python sets are unordered while RooArgSets are ordered, and this mismatch can lead to subtle problems later on. Prefer conversion from Python lists or tuples, which are ordered too.
5252
* The ROOT IO capability for the `TMVA::Experimental::SOFIE::RModel` has been removed. Users should not be encouraged to serialize models in experimental classes. For the serialization of ONNX models one can already use ONNX directly, and even serialize the ONNX bytes to a ROOT file if required.
5353
* The **JsMVA** feature for interactive TMVA training in Jupyter notebooks is now removed. It was not functional for years and was therefore already excluded from ROOT 6.38. This also removes the `TMVA::IPythonInteractive` class and the related interactive-training interfaces from the TMVA method and fitter classes, such as `MethodBase::ExitFromTraining()` or `FitterBase::SetIPythonInteractive()`.
54+
* The **RooStats::DebuggingSampler** and **RooStats::DebuggingTestStat** classes are removed. They were mock implementations of the `TestStatSampler` and `TestStatistic` interfaces that returned uniform random numbers independent of the data, only meant for debugging the RooStats framework itself during its initial development.
5455

5556
## Python Interface
5657

roofit/roostats/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ ROOT_STANDARD_LIBRARY_PACKAGE(RooStats
2222
RooStats/CombinedCalculator.h
2323
RooStats/ConfidenceBelt.h
2424
RooStats/ConfInterval.h
25-
RooStats/DebuggingSampler.h
26-
RooStats/DebuggingTestStat.h
2725
RooStats/DetailedOutputAggregator.h
2826
RooStats/FeldmanCousins.h
2927
RooStats/FrequentistCalculator.h

roofit/roostats/inc/LinkDef.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,10 @@
5454
#pragma link C++ class RooStats::DetailedOutputAggregator+;
5555

5656
#pragma link C++ class RooStats::TestStatSampler+; // interface, not concrete
57-
#pragma link C++ class RooStats::DebuggingSampler+;
5857
#pragma link C++ class RooStats::ToyMCSampler+;
5958
#pragma link C++ class RooStats::ToyMCImportanceSampler+;
6059

6160
#pragma link C++ class RooStats::TestStatistic+; // interface
62-
#pragma link C++ class RooStats::DebuggingTestStat+;
6361
#pragma link C++ class RooStats::ProfileLikelihoodTestStat+;
6462
#pragma link C++ class RooStats::RatioOfProfiledLikelihoodsTestStat+;
6563
#pragma link C++ class RooStats::NumEventsTestStat+;

roofit/roostats/inc/RooStats/DebuggingSampler.h

Lines changed: 0 additions & 113 deletions
This file was deleted.

roofit/roostats/inc/RooStats/DebuggingTestStat.h

Lines changed: 0 additions & 67 deletions
This file was deleted.

0 commit comments

Comments
 (0)