[ntuple] mark some move constructors noexcept

Author: jblomer

tree/ntuple/inc/ROOT/RFieldBase.hxx

@@ -790,8 +790,8 @@ public:
       fTypeInfo = nullptr;
       return *this;
    }
-   RValue(RValue &&other) : fField(other.fField), fObjPtr(std::move(other.fObjPtr)) {}
-   RValue &operator=(RValue &&other)
+   RValue(RValue &&other) noexcept : fField(other.fField), fObjPtr(std::move(other.fObjPtr)) {}
+   RValue &operator=(RValue &&other) noexcept
    {
       fField = other.fField;
       fObjPtr = other.fObjPtr;
@@ -927,8 +927,8 @@ public:
    ~RBulkValues();
    RBulkValues(const RBulkValues &) = delete;
    RBulkValues &operator=(const RBulkValues &) = delete;
-   RBulkValues(RBulkValues &&other);
-   RBulkValues &operator=(RBulkValues &&other);
+   RBulkValues(RBulkValues &&other) noexcept;
+   RBulkValues &operator=(RBulkValues &&other) noexcept;
 
    // Sets `fValues` and `fSize`/`fCapacity` to the given values. The capacity is specified in number of values.
    // Once a buffer is adopted, an attempt to read more values then available throws an exception.

tree/ntuple/inc/ROOT/RNTupleAttrWriting.hxx

@@ -75,10 +75,10 @@ public:
    RNTupleAttrPendingRange(const RNTupleAttrPendingRange &) = delete;
    RNTupleAttrPendingRange &operator=(const RNTupleAttrPendingRange &) = delete;
 
-   RNTupleAttrPendingRange(RNTupleAttrPendingRange &&other) { *this = std::move(other); }
+   RNTupleAttrPendingRange(RNTupleAttrPendingRange &&other) noexcept { *this = std::move(other); }
 
    // NOTE: explicitly implemented to make sure that 'other' gets invalidated upon move.
-   RNTupleAttrPendingRange &operator=(RNTupleAttrPendingRange &&other)
+   RNTupleAttrPendingRange &operator=(RNTupleAttrPendingRange &&other) noexcept
    {
       if (&other != this) {
          std::swap(fStart, other.fStart);

tree/ntuple/inc/ROOT/RNTupleReader.hxx

@@ -173,9 +173,9 @@ public:
    public:
       ~RActiveEntryToken() { Reset(); }
       RActiveEntryToken(const RActiveEntryToken &other);
-      RActiveEntryToken(RActiveEntryToken &&other);
+      RActiveEntryToken(RActiveEntryToken &&other) noexcept;
       RActiveEntryToken &operator=(const RActiveEntryToken &other);
-      RActiveEntryToken &operator=(RActiveEntryToken &&other);
+      RActiveEntryToken &operator=(RActiveEntryToken &&other) noexcept;
 
       NTupleSize_t GetEntryNumber() const { return fEntryNumber; }
       /// Set or replace the entry number. If the entry number is replaced, the cluster corresponding to the new

tree/ntuple/inc/ROOT/RNTupleView.hxx

@@ -365,11 +365,11 @@ private:
 public:
    RNTupleCollectionView(const RNTupleCollectionView &other) = delete;
    RNTupleCollectionView &operator=(const RNTupleCollectionView &other) = delete;
-   RNTupleCollectionView(RNTupleCollectionView &&other)
+   RNTupleCollectionView(RNTupleCollectionView &&other) noexcept(false)
       : fSource(other.fSource), fField(std::move(other.fField)), fValue(fField.CreateValue())
    {
    }
-   RNTupleCollectionView &operator=(RNTupleCollectionView &&other)
+   RNTupleCollectionView &operator=(RNTupleCollectionView &&other) noexcept(false)
    {
       if (this == &other)
          return *this;

tree/ntuple/inc/ROOT/RPageSinkBuf.hxx

@@ -52,8 +52,8 @@ class RPageSinkBuf : public RPageSink {
       RColumnBuf() = default;
       RColumnBuf(const RColumnBuf&) = delete;
       RColumnBuf& operator=(const RColumnBuf&) = delete;
-      RColumnBuf(RColumnBuf&&) = default;
-      RColumnBuf& operator=(RColumnBuf&&) = default;
+      RColumnBuf(RColumnBuf &&) noexcept = default;
+      RColumnBuf &operator=(RColumnBuf &&) noexcept = default;
       ~RColumnBuf() { DropBufferedPages(); }
 
       /// Returns a reference to the newly buffered page. The reference remains

tree/ntuple/src/RFieldBase.cxx

@@ -129,7 +129,7 @@ void ROOT::RFieldBase::RValue::BindRawPtr(void *rawPtr)
 
 //------------------------------------------------------------------------------
 
-ROOT::RFieldBase::RBulkValues::RBulkValues(RBulkValues &&other)
+ROOT::RFieldBase::RBulkValues::RBulkValues(RBulkValues &&other) noexcept
    : fField(other.fField),
      fValueSize(other.fValueSize),
      fCapacity(other.fCapacity),
@@ -143,7 +143,7 @@ ROOT::RFieldBase::RBulkValues::RBulkValues(RBulkValues &&other)
    std::swap(fMaskAvail, other.fMaskAvail);
 }
 
-ROOT::RFieldBase::RBulkValues &ROOT::RFieldBase::RBulkValues::operator=(RBulkValues &&other)
+ROOT::RFieldBase::RBulkValues &ROOT::RFieldBase::RBulkValues::operator=(RBulkValues &&other) noexcept
 {
    std::swap(fField, other.fField);
    std::swap(fDeleter, other.fDeleter);

tree/ntuple/src/RNTupleReader.cxx

@@ -84,7 +84,7 @@ ROOT::RNTupleReader::RActiveEntryToken::RActiveEntryToken(const RActiveEntryToke
    SetEntryNumber(other.fEntryNumber);
 }
 
-ROOT::RNTupleReader::RActiveEntryToken::RActiveEntryToken(RActiveEntryToken &&other)
+ROOT::RNTupleReader::RActiveEntryToken::RActiveEntryToken(RActiveEntryToken &&other) noexcept
 {
    std::swap(fEntryNumber, other.fEntryNumber);
    std::swap(fPtrControlBlock, other.fPtrControlBlock);
@@ -105,7 +105,8 @@ ROOT::RNTupleReader::RActiveEntryToken::operator=(const RActiveEntryToken &other
    return *this;
 }
 
-ROOT::RNTupleReader::RActiveEntryToken &ROOT::RNTupleReader::RActiveEntryToken::operator=(RActiveEntryToken &&other)
+ROOT::RNTupleReader::RActiveEntryToken &
+ROOT::RNTupleReader::RActiveEntryToken::operator=(RActiveEntryToken &&other) noexcept
 {
    std::swap(fEntryNumber, other.fEntryNumber);
    std::swap(fPtrControlBlock, other.fPtrControlBlock);