Skip to content

Commit 240db97

Browse files
committed
Remove JsMVA source code
The JsMVA features were not functional for years, and therefore excluded from ROOT 6.38 with commit 41f7ac4. Therefore, for ROOT 6.42, it's appropriate to remove the sources for good.
1 parent 9ea4ec6 commit 240db97

59 files changed

Lines changed: 36 additions & 6042 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -356,9 +356,6 @@ file(GLOB_RECURSE artifact_files RELATIVE ${CMAKE_SOURCE_DIR} etc/*)
356356
# Exclude the *.in files, just like in the install tree
357357
list(FILTER artifact_files EXCLUDE REGEX "\.(in)$")
358358

359-
# Exclude etc/notebook/JsMVA
360-
list(FILTER artifact_files EXCLUDE REGEX "^etc/notebook/JsMVA/")
361-
362359
foreach(artifact_file ${artifact_files})
363360
add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${artifact_file}
364361
COMMAND ${CMAKE_COMMAND} -E copy_if_different ${CMAKE_SOURCE_DIR}/${artifact_file} ${CMAKE_BINARY_DIR}/${artifact_file}
@@ -530,7 +527,6 @@ install(
530527
PATTERN "*.pcm"
531528
PATTERN "modules.idx"
532529
PATTERN "JupyROOT" EXCLUDE
533-
PATTERN "JsMVA" EXCLUDE
534530
PATTERN "python*" EXCLUDE
535531
PATTERN "cmake" EXCLUDE
536532
PATTERN "pkgconfig" EXCLUDE
@@ -637,7 +633,6 @@ if(NOT CMAKE_SOURCE_DIR STREQUAL CMAKE_INSTALL_PREFIX)
637633
endif()
638634
install(DIRECTORY etc/ DESTINATION ${CMAKE_INSTALL_SYSCONFDIR} USE_SOURCE_PERMISSIONS
639635
${DIR_PERMISSIONS}
640-
PATTERN "notebook/JsMVA" EXCLUDE
641636
PATTERN "system.rootrc" EXCLUDE
642637
PATTERN "root.mimes" EXCLUDE
643638
PATTERN "*.in" EXCLUDE)

README/ReleaseNotes/v642/index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ The following people have contributed to this new version:
5050
* The inclusion by external projects of Makefile templates contained within ROOT is deprecated in 6.42, a warning will be raised if you use them. These files will be removed in ROOT 7.
5151
* The conversion from Python set to **RooArgSet** is deprecated and won't work anymore in ROOT 6.44. The problem is that Python sets are unordered while RooArgSets are ordered, and this mismatch can lead to subtle problems later on. Prefer conversion from Python lists or tuples, which are ordered too.
5252
* The ROOT IO capability for the `TMVA::Experimental::SOFIE::RModel` has been removed. Users should not be encouraged to serialize models in experimental classes. For the serialization of ONNX models one can already use ONNX directly, and even serialize the ONNX bytes to a ROOT file if required.
53+
* The **JsMVA** feature for interactive TMVA training in Jupyter notebooks is now removed. It was not functional for years and was therefore already excluded from ROOT 6.38. This also removes the `TMVA::IPythonInteractive` class and the related interactive-training interfaces from the TMVA method and fitter classes, such as `MethodBase::ExitFromTraining()` or `FitterBase::SetIPythonInteractive()`.
5354

5455
## Python Interface
5556

bindings/pyroot/pythonizations/python/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,6 @@ if(tmva)
8989
endif()
9090

9191
set(py_sources
92-
#ROOT/JsMVA/DataLoader.py
93-
#ROOT/JsMVA/Factory.py
94-
#ROOT/JsMVA/JPyInterface.py
95-
#ROOT/JsMVA/JsMVAMagic.py
96-
#ROOT/JsMVA/OutputTransformer.py
97-
#ROOT/JsMVA/__init__.py
9892
ROOT/_application.py
9993
ROOT/_asan.py
10094
ROOT/_facade.py

bindings/pyroot/pythonizations/python/ROOT/JsMVA/DataLoader.py

Lines changed: 0 additions & 148 deletions
This file was deleted.

0 commit comments

Comments
 (0)