io: Skip large collection test when not enough memory

Author: pcanal

cmake/modules/RootTestDriver.cmake

@@ -132,7 +132,12 @@ endif()
 #---Execute pre-command-----------------------------------------------------------------------------
 if(PRE)
   execute_process(COMMAND ${_pre} ${_cwd} RESULT_VARIABLE _rc)
-  if(_rc)
+  if(_rc EQUAL 77)
+    # Exit code 77 from a pre-command means "skip this test".
+    # Print a sentinel recognised by SKIP_REGULAR_EXPRESSION on the test.
+    message(STATUS "ROOTTEST_SKIP: pre-command requested skip -- skipping test")
+    return()
+  elseif(_rc)
     message(FATAL_ERROR "pre-command error code : ${_rc}")
   endif()
 endif()

io/io/test/CMakeLists.txt

@@ -66,9 +66,52 @@ if(NOT _32BIT)
   ROOTTEST_COMPILE_MACRO(testLargeCollection.cxx
                         FIXTURES_SETUP io-io-testcoll-fixture)
 
+  # Memory-check script: exits 0 when enough RAM+swap is available, 77 (skip) otherwise.
+  # RootTestDriver.cmake propagates exit code 77 from PRECMD to the test's own exit code,
+  # and SKIP_RETURN_CODE 77 on the main test turns that into a proper CTest "Skipped".
+  set(_memcheck_script "${CMAKE_CURRENT_BINARY_DIR}/check_mem_for_large_coll.sh")
+  file(WRITE ${_memcheck_script}
+    "#!/bin/sh\n"
+    "# Exit 77 (CTest SKIP via SKIP_RETURN_CODE) if total RAM+swap < 32 GB.\n"
+    "# We use TOTAL (not free) because the OS reclaims cached pages on demand.\n"
+    "THRESHOLD_KB=33554432\n"
+    "if [ -r /proc/meminfo ]; then\n"
+    "  # Linux: use MemTotal + SwapTotal (kernel will reclaim caches as needed)\n"
+    "  RAM_KB=\$(awk '/^MemTotal:/{print \$2}' /proc/meminfo)\n"
+    "  SWAP_KB=\$(awk '/^SwapTotal:/{print \$2}' /proc/meminfo)\n"
+    "  RAM_KB=\${RAM_KB:-0}\n"
+    "  SWAP_KB=\${SWAP_KB:-0}\n"
+    "  TOTAL_KB=\$(( RAM_KB + SWAP_KB ))\n"
+    "elif [ \"\$(uname)\" = \"Darwin\" ]; then\n"
+    "  # macOS: total physical RAM via sysctl hw.memsize (bytes -> kB)\n"
+    "  RAM_BYTES=\$(sysctl -n hw.memsize 2>/dev/null)\n"
+    "  RAM_KB=\$(( \${RAM_BYTES:-0} / 1024 ))\n"
+    "  # sysctl output: 'total = NNN.NNM  used = ...  free = ...'\n"
+    "  SWAP_TOTAL_MB=\$(sysctl -n vm.swapusage 2>/dev/null | sed 's/total = \\([0-9.]*\\)M.*/\\1/')\n"
+    "  if [ -n \"\$SWAP_TOTAL_MB\" ]; then\n"
+    "    SWAP_KB=\$(awk \"BEGIN{printf \\\"%d\\\", \$SWAP_TOTAL_MB * 1024}\")\n"
+    "  else\n"
+    "    SWAP_KB=0\n"
+    "  fi\n"
+    "  TOTAL_KB=\$(( RAM_KB + SWAP_KB ))\n"
+    "else\n"
+    "  echo \"testLargeCollections memory check: unsupported OS, assuming enough memory\"\n"
+    "  exit 0\n"
+    "fi\n"
+    "echo \"testLargeCollections memory check: total \${TOTAL_KB} kB (RAM \${RAM_KB} + swap \${SWAP_KB}), need \${THRESHOLD_KB} kB\"\n"
+    "if [ \"\$TOTAL_KB\" -lt \"\$THRESHOLD_KB\" ]; then\n"
+    "  echo \"Insufficient memory -- skipping testLargeCollections\"\n"
+    "  exit 77\n"
+    "fi\n"
+    "exit 0\n"
+  )
+  execute_process(COMMAND chmod +x ${_memcheck_script})
+
   ROOTTEST_ADD_TEST(testLargeCollections
                     TIMEOUT 1200
                     MACRO testLargeCollection.cxx+
                     OUTREF testLargeCollection.ref
-                    FIXTURES_REQUIRED io-io-testcoll-fixture)
+                    FIXTURES_REQUIRED io-io-testcoll-fixture
+                    PRECMD sh ${_memcheck_script}
+                    PROPERTIES "SKIP_REGULAR_EXPRESSION;ROOTTEST_SKIP")
 endif()

io/io/test/testLargeCollection.cxx

@@ -16,19 +16,32 @@
 #include <iostream>
 #include <limits>
 #include <vector>
+#if !defined(_WIN32)
 #include <sys/resource.h>
+#endif
 #if defined(__APPLE__)
 #include <sys/sysctl.h>
 #elif defined(__linux__)
 #include <sys/sysinfo.h>
 #elif defined(_WIN32)
+#ifndef WIN32_LEAN_AND_MEAN
+#define WIN32_LEAN_AND_MEAN
+#endif
+#ifndef NOMINMAX
+#define NOMINMAX
+#endif
 #include <windows.h>
+#include <psapi.h>
 #endif
 
 // Timing helper — writes to a dedicated file, not captured by the ctest driver.
 static std::ofstream &timingLog()
 {
+#if defined(_WIN32)
+   static std::ofstream f("testLargeCollection_timing.txt");
+#else
    static std::ofstream f("/tmp/testLargeCollection_timing.txt");
+#endif
    return f;
 }
 static double now_sec()
@@ -41,13 +54,20 @@ static double now_sec()
 // ru_maxrss is bytes on macOS, kilobytes on Linux.
 static double peak_rss_mb()
 {
+#if defined(_WIN32)
+   PROCESS_MEMORY_COUNTERS pmc;
+   if (GetProcessMemoryInfo(GetCurrentProcess(), &pmc, sizeof(pmc)))
+      return pmc.PeakWorkingSetSize / (1024.0 * 1024.0);
+   return -1.0;
+#else
    struct rusage ru;
    getrusage(RUSAGE_SELF, &ru);
 #if defined(__APPLE__)
    return ru.ru_maxrss / (1024.0 * 1024.0);
 #else
    return ru.ru_maxrss / 1024.0;
 #endif
+#endif
 }
 // Returns the available (free) physical memory in MB.
 static double available_mem_mb()