Skip to content

Commit 3d1be6b

Browse files
committed
Disable R__DEPRECATED on gcc 5.3
It does not support deprecation of enumerators (reproducer at https://godbolt.org/z/1TEo5M), which breaks compilation e.g. on Ubuntu 16.
1 parent 4880869 commit 3d1be6b

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

core/foundation/inc/ROOT/RConfig.hxx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -462,9 +462,10 @@
462462

463463
/*---- deprecation -----------------------------------------------------------*/
464464
#if defined(__GNUC__) || defined(__clang__) || defined(__INTEL_COMPILER)
465-
# if (__GNUC__ == 5 && (__GNUC_MINOR__ == 1 || __GNUC_MINOR__ == 2)) || defined(R__NO_DEPRECATION)
466-
/* GCC 5.1, 5.2: false positives due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=15269
467-
or deprecation turned off */
465+
# if (__GNUC__ == 5 && (__GNUC_MINOR__ == 1 || __GNUC_MINOR__ == 2 || __GNUC_MINOR__ == 3)) || defined(R__NO_DEPRECATION)
466+
/* GCC 5.1, 5.2: false positives due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=15269,
467+
GCC 5.3: broken compilation when deprecating enumerators: https://godbolt.org/z/1TEo5M,
468+
deprecation turned off */
468469
# define _R__DEPRECATED_LATER(REASON)
469470
# else
470471
# define _R__DEPRECATED_LATER(REASON) __attribute__((deprecated(REASON)))

0 commit comments

Comments
 (0)