Skip to content

Commit 45eb0cc

Browse files
committed
[ntuple] fix virtual destructor visibility
1 parent 42a81c3 commit 45eb0cc

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

tree/ntuple/inc/ROOT/RField/RFieldFundamental.hxx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,14 +412,13 @@ protected:
412412
fPrincipalColumn = fAvailableColumns[0].get();
413413
}
414414

415-
~RRealField() override = default;
416-
417415
public:
418416
using Base::SetColumnRepresentatives;
419417

420418
RRealField(std::string_view name, std::string_view typeName) : RSimpleField<T>(name, typeName) {}
421419
RRealField(RRealField &&other) = default;
422420
RRealField &operator=(RRealField &&other) = default;
421+
~RRealField() override = default;
423422

424423
/// Sets this field to use a half precision representation, occupying half as much storage space (16 bits:
425424
/// 1 sign bit, 5 exponent bits, 10 mantissa bits) on disk.

tree/ntuple/inc/ROOT/RFieldVisitor.hxx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ As an example of a concrete use case, see Internal::RPrintSchemaVisitor.
5656
// clang-format on
5757
class RFieldVisitor {
5858
public:
59+
virtual ~RFieldVisitor() = default;
60+
5961
virtual void VisitField(const ROOT::RFieldBase &field) = 0;
6062
virtual void VisitFieldZero(const ROOT::RFieldZero &field) { VisitField(field); }
6163
virtual void VisitArrayField(const ROOT::RArrayField &field) { VisitField(field); }

0 commit comments

Comments
 (0)