Skip to content

Commit 6bae7b0

Browse files
committed
[ci][docs] Make actionlint and shellcheck happier with the workflow.
- Quote many variables to prevent word splitting or unwanted globbing
1 parent b20b3b0 commit 6bae7b0

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

.github/workflows/root-docs-ci.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@ jobs:
9494
shell: bash
9595
run: |
9696
source ROOT-CI/build/bin/thisroot.sh
97-
export DOXYGEN_OUTPUT_DIRECTORY=/github/home/${DOC_DIR}
97+
export DOXYGEN_OUTPUT_DIRECTORY="/github/home/${DOC_DIR}"
9898
cd ROOT-CI/src/documentation/doxygen
99-
make -j `nproc --all`
99+
make -j "$(nproc --all)"
100100
101101
- name: Create documentation archives
102102
working-directory: ${{ env.DOC_LOCATION }}
@@ -133,20 +133,20 @@ jobs:
133133
# them by extension. Once that is fixed in XRootD, a single command can be used
134134
# instead.
135135
run: |
136-
echo ${RWEBEOS_KT} | base64 -d > ${KT_FILE_NAME}
137-
kinit -p ${{ secrets.KRB5USER }}@${{ secrets.KRB5REALM }} -kt ${KT_FILE_NAME}
138-
cd ${DOC_DIR}/html/
139-
xrdcp --parallel 64 -rf ./*.html ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
140-
rm -rf *.html
141-
xrdcp --parallel 64 -rf ./*.svg ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
142-
rm -rf *.svg
143-
xrdcp --parallel 64 -rf ./*.map ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
144-
rm -rf *.map
145-
xrdcp --parallel 64 -rf ./*.md5 ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
146-
rm -rf *.md5
147-
xrdcp --parallel 64 -rf ./ ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
136+
echo "${RWEBEOS_KT}" | base64 -d > "${KT_FILE_NAME}"
137+
kinit -p "${{ secrets.KRB5USER }}@${{ secrets.KRB5REALM }}" -kt "${KT_FILE_NAME}"
138+
cd "${DOC_DIR}/html/"
139+
xrdcp --parallel 64 -rf ./*.html "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
140+
rm -rf ./*.html
141+
xrdcp --parallel 64 -rf ./*.svg "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
142+
rm -rf ./*.svg
143+
xrdcp --parallel 64 -rf ./*.map "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
144+
rm -rf ./*.map
145+
xrdcp --parallel 64 -rf ./*.md5 "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
146+
rm -rf ./*.md5
147+
xrdcp --parallel 64 -rf ./ "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
148148
cd ..
149149
rm -r html
150-
xrdcp --parallel 64 -rf ./ ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
150+
xrdcp --parallel 64 -rf ./ "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
151151
cd ..
152-
xrdcp -rf ${TAR_FILE} ${EOS_ENDPOINT}/${EOS_BASE_PATH}/download
152+
xrdcp -rf "${TAR_FILE}" "${EOS_ENDPOINT}/${EOS_BASE_PATH}/download"

0 commit comments

Comments
 (0)