Skip to content

Commit 708f66e

Browse files
committed
[ci][docs] Make actionlint and shellcheck happier with the workflow.
- Quote many variables to prevent word splitting or unwanted globbing
1 parent 42b7b41 commit 708f66e

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

.github/workflows/root-docs-ci.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ jobs:
9696
shell: bash
9797
run: |
9898
source ROOT-CI/build/bin/thisroot.sh
99-
export DOXYGEN_OUTPUT_DIRECTORY=/github/home/${DOC_DIR}
99+
export DOXYGEN_OUTPUT_DIRECTORY="/github/home/${DOC_DIR}"
100100
cd ROOT-CI/src/documentation/doxygen
101-
make -j `nproc --all`
101+
make -j "$(nproc --all)"
102102
103103
- name: Create documentation archives
104104
working-directory: ${{ env.DOC_LOCATION }}
@@ -138,20 +138,20 @@ jobs:
138138
# them by extension. Once that is fixed in XRootD, a single command can be used
139139
# instead.
140140
run: |
141-
echo ${RWEBEOS_KT} | base64 -d > ${KT_FILE_NAME}
142-
kinit -p ${{ secrets.KRB5USER }}@${{ secrets.KRB5REALM }} -kt ${KT_FILE_NAME}
143-
cd ${DOC_DIR}/html/
144-
xrdcp --parallel 64 -rf ./*.html ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
145-
rm -rf *.html
146-
xrdcp --parallel 64 -rf ./*.svg ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
147-
rm -rf *.svg
148-
xrdcp --parallel 64 -rf ./*.map ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
149-
rm -rf *.map
150-
xrdcp --parallel 64 -rf ./*.md5 ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
151-
rm -rf *.md5
152-
xrdcp --parallel 64 -rf ./ ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
141+
echo "${RWEBEOS_KT}" | base64 -d > "${KT_FILE_NAME}"
142+
kinit -p "${{ secrets.KRB5USER }}@${{ secrets.KRB5REALM }}" -kt "${KT_FILE_NAME}"
143+
cd "${DOC_DIR}/html/"
144+
xrdcp --parallel 64 -rf ./*.html "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
145+
rm -rf ./*.html
146+
xrdcp --parallel 64 -rf ./*.svg "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
147+
rm -rf ./*.svg
148+
xrdcp --parallel 64 -rf ./*.map "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
149+
rm -rf ./*.map
150+
xrdcp --parallel 64 -rf ./*.md5 "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
151+
rm -rf ./*.md5
152+
xrdcp --parallel 64 -rf ./ "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
153153
cd ..
154154
rm -r html
155-
xrdcp --parallel 64 -rf ./ ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
155+
xrdcp --parallel 64 -rf ./ "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
156156
cd ..
157-
xrdcp -rf ${TAR_NAME}.gz ${EOS_ENDPOINT}/${EOS_BASE_PATH}/download
157+
xrdcp -rf "${TAR_NAME}.gz" "${EOS_ENDPOINT}/${EOS_BASE_PATH}/download"

0 commit comments

Comments
 (0)