[core][RF][misc][interpreter] Fix various compiler warnings

* [RF] fix windows warning

C:\ROOT-CI\src\roofit\roofitcore\src\RooLinkedList.cxx(71,19): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\ROOT-CI\build\roofit\roofitcore\RooFitCore.vcxproj]

* [core] fix unused var warning

* Update RooLinkedList.cxx

* [misc] fix win32 main return warning

warning C4326: return type of 'main' should be 'int' instead of 'void'

* [RF] unsafe mix int bool

warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation

* [RF] use nullptr and fix typo

* [RF] fix unsafe mix int bool

 warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation

* [RF] cast bool to int

warning C4804: '/': unsafe use of type 'bool' in operation

* [io,test] fix overflow warning

warning C4756: overflow in constant arithmetic

* [tmva,sofie] fix win warnings

discarding return value of function with [[nodiscard]] attribute

* [llvm] silence some windows warnings

* [RF] fix wrong ret value and fix warning

* Apply suggestions from code review

Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>

* Update w32pragma.h

* Apply suggestion from @ferdymercury

* [core] print exception message

Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>

Author: ferdymercury

cmake/win/w32pragma.h

@@ -49,7 +49,7 @@
 #pragma warning (disable: 4503)
 
 /* function is hidden */
-#pragma warning (3: 4266)
+#pragma warning (disable: 4266)
 /* loop control variable is used outside the for-loop scope */
 #pragma warning (3: 4289)
 

core/base/src/TROOT.cxx

@@ -340,7 +340,7 @@ namespace {
             try {
                desiredValue = std::stoi(env);
             } catch (std::invalid_argument &e) {
-               Error("TROOT", "%s should be 0 or 1", envName);
+               Error("TROOT", "%s should be 0 or 1, exception message: '%s'", envName, e.what());
             }
             if (desiredValue == 0) {
                autoReg = AutoReg::kOff;

io/io/test/TBufferJSONTests.cxx

@@ -119,7 +119,14 @@ TEST(TBufferJSON, SpecialNumbersFloat)
    p = nullptr;
 
    auto maxVal = std::numeric_limits<float>::max(); // 3.40282e+38f
+   #ifdef WIN32
+   #pragma warning( push )
+   #pragma warning( disable : 4756 ) // overflow in constant arithmetic
+   #endif
    auto ovfVal = std::numeric_limits<float>::max() * static_cast<float>(1 + 1e-7);
+   #ifdef WIN32
+   #pragma warning( pop )
+   #endif
    auto infVal = std::numeric_limits<float>::infinity();
    EXPECT_EQ(ovfVal, infVal);
    auto nanVal = std::numeric_limits<float>::quiet_NaN();

misc/win/bindexplib/bindexplib.cxx

@@ -470,7 +470,7 @@ void bindexplib::WriteFile(FILE *file)
 }
 
 
-void
+int
 main(int argc, char **argv)
 {
    std::string cmdline;
@@ -484,7 +484,7 @@ main(int argc, char **argv)
    if (argc < 3) {
 Usage:
       fprintf(stderr, "Usage: %s ?-o outfile? ?-f(ull)? <dllname> <object filenames> ..\n", argv[0]);
-      exit(1);
+      return EXIT_FAILURE;
    }
 
    arg = 1;
@@ -515,7 +515,7 @@ main(int argc, char **argv)
          fprintf(stderr, "Unable to open \'%s\' for writing:\n",
                  argv[arg]);
          perror("");
-         exit(1);
+         return EXIT_FAILURE;
       }
    } else {
       fout = stdout;
@@ -543,7 +543,7 @@ main(int argc, char **argv)
             fprintf(stderr, "Unable to open \'%s\' for reading:\n",
                     argv[arg]);
             perror("");
-            exit(1);
+            return EXIT_FAILURE;
          }
          char *fargv[1000];
          for (i = 0; i < arg; i++) {
@@ -566,7 +566,7 @@ main(int argc, char **argv)
       if (SearchFile == INVALID_HANDLE_VALUE) {
          fprintf(stderr, "Unable to find \'%s\' for reading:\n",
                  argv[arg]);
-         exit(1);
+         return EXIT_FAILURE;
       } else {
          /*
          *  Since WIN32_FIND_DATA has no path information one has to extract it oneself.
@@ -588,5 +588,5 @@ main(int argc, char **argv)
          deffile.WriteFile(fout);
       }
    }
-   exit(0);
+   return EXIT_SUCCESS;
 }

roofit/batchcompute/src/ComputeFunctions.cxx

@@ -399,7 +399,7 @@ __rooglobal__ void computeGamma(Batches &batches)
    double gamma = -std::lgamma(G[0]);
    for (size_t i = BEGIN; i < batches.nEvents; i += STEP) {
       if (X[i] == M[i]) {
-         batches.output[i] = (G[i] == 1.0) / B[i];
+         batches.output[i] = int(G[i] == 1.0) / B[i];
       } else if (G._isVector) {
          batches.output[i] = -std::lgamma(G[i]);
       } else {

roofit/roofit/test/testFitPerf.cxx

@@ -563,12 +563,12 @@ int FitUsingRooFit(TTree *tree, TF1 *func)
 #ifdef DEBUG
       mean.Print();
       sigma.Print();
-      assert(result != 0);
+      assert(result != nullptr);
       std::cout << " Roofit status " << result->status() << std::endl;
       result->Print();
 #endif
       if (save)
-         iret |= (result == 0);
+         iret |= int(result == nullptr);
 
       if (iret != 0) {
          std::cout << "Fit failed " << std::endl;
@@ -648,12 +648,12 @@ int FitUsingRooFit2(TTree *tree)
          pdf[N - 1]->fitTo(data, RooFit::Minos(0), RooFit::Hesse(1), RooFit::PrintLevel(level), RooFit::Save(save))};
 
 #ifdef DEBUG
-      assert(result != 0);
-      std::cout << " Roofit status " << result->status() << std::endl;
-      result->Print();
+      assert(result == nullptr);
+//std::cout << " Roofit status " << result->status() << std::endl;
+//result->Print();
 #endif
 
-      iret |= (result != 0);
+      iret |= int(result != nullptr);
 
       if (iret != 0)
          return iret;

roofit/roofit/test/testRooFit.cxx

@@ -209,7 +209,7 @@ int FitUsingRooFit(TTree &tree, RooAbsPdf &pdf, RooArgSet &xvars)
       std::cout << " Roofit status " << result->status() << std::endl;
       result->Print();
 #endif
-      iret |= (result == nullptr);
+      iret |= int(result == nullptr);
    }
 
    w.Stop();

roofit/roofitcore/src/RooLinkedList.cxx

@@ -68,7 +68,7 @@ namespace RooLinkedListImplDetails {
       ~Chunk() { delete[] _chunk; }
       /// chunk capacity
       Int_t capacity() const
-      { return (1 << _sz) / sizeof(RooLinkedListElem); }
+      { return (1ULL << _sz) / sizeof(RooLinkedListElem); }
       /// chunk free elements
       Int_t free() const { return _free; }
       /// chunk occupied elements

tmva/sofie/src/RModel.cxx

@@ -1549,7 +1549,7 @@ void RModel::ReadInitializedTensorsFromFile(long pos) {
                fGC += "      fTensor_" + i.first + " = *reinterpret_cast<std::vector<int64_t>*>(rootFile->Get(\"";
                fGC += dirName + "/" + tensor_name + "\"));\n";
             } else {
-               std::runtime_error("tmva-sofie tensor " + tensor_name + " with type " + ConvertTypeToString(i.second.type()) + " cannot be read from a ROOT file");
+               throw std::runtime_error("tmva-sofie tensor " + tensor_name + " with type " + ConvertTypeToString(i.second.type()) + " cannot be read from a ROOT file");
             }
             fGC += "  }\n";
         }
@@ -1617,7 +1617,7 @@ long RModel::WriteInitializedTensorsToFile(std::string filename) {
                outputDir->WriteObjectAny(&tensorDataVector, "std::vector<int64_t>", tensorName.c_str());
             }
             else {
-               std::runtime_error("tmva-sofie tensor " + tensorName + " with type " + ConvertTypeToString(item.second.type()) +
+               throw std::runtime_error("tmva-sofie tensor " + tensorName + " with type " + ConvertTypeToString(item.second.type()) +
                                   " cannot be written to a ROOT file");
             }
         }
@@ -1668,7 +1668,7 @@ long RModel::WriteInitializedTensorsToFile(std::string filename) {
                throw std::runtime_error("tmva-sofie tensor " + tensor_name + " with type " + ConvertTypeToString(i.second.type()) + " cannot be written to a file");
             }
             if (f.fail())
-               std::runtime_error("tmva-sofie failed to write tensor data to file for  " + tensor_name);
+               throw std::runtime_error("tmva-sofie failed to write tensor data to file for  " + tensor_name);
         }
         long curr_pos = f.tellp();
         f.close();