Skip to content

Commit a74379f

Browse files
committed
[ci][docs] Make actionlint and shellcheck happier with the workflow.
- Quote many variables to prevent word splitting or unwanted globbing
1 parent 2388a71 commit a74379f

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

.github/workflows/root-docs-ci.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@ jobs:
9393
shell: bash
9494
run: |
9595
source ROOT-CI/build/bin/thisroot.sh
96-
export DOXYGEN_OUTPUT_DIRECTORY=/github/home/${DOC_DIR}
96+
export DOXYGEN_OUTPUT_DIRECTORY="/github/home/${DOC_DIR}"
9797
cd ROOT-CI/src/documentation/doxygen
98-
make -j `nproc --all`
98+
make -j "$(nproc --all)"
9999
100100
- name: Create documentation archives
101101
working-directory: ${{ env.DOC_LOCATION }}
@@ -132,20 +132,20 @@ jobs:
132132
# them by extension. Once that is fixed in XRootD, a single command can be used
133133
# instead.
134134
run: |
135-
echo ${RWEBEOS_KT} | base64 -d > ${KT_FILE_NAME}
136-
kinit -p ${{ secrets.KRB5USER }}@${{ secrets.KRB5REALM }} -kt ${KT_FILE_NAME}
137-
cd ${DOC_DIR}/html/
138-
xrdcp --parallel 64 -rf ./*.html ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
139-
rm -rf *.html
140-
xrdcp --parallel 64 -rf ./*.svg ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
141-
rm -rf *.svg
142-
xrdcp --parallel 64 -rf ./*.map ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
143-
rm -rf *.map
144-
xrdcp --parallel 64 -rf ./*.md5 ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
145-
rm -rf *.md5
146-
xrdcp --parallel 64 -rf ./ ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
135+
echo "${RWEBEOS_KT}" | base64 -d > "${KT_FILE_NAME}"
136+
kinit -p "${{ secrets.KRB5USER }}@${{ secrets.KRB5REALM }}" -kt "${KT_FILE_NAME}"
137+
cd "${DOC_DIR}/html/"
138+
xrdcp --parallel 64 -rf ./*.html "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
139+
rm -rf ./*.html
140+
xrdcp --parallel 64 -rf ./*.svg "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
141+
rm -rf ./*.svg
142+
xrdcp --parallel 64 -rf ./*.map "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
143+
rm -rf ./*.map
144+
xrdcp --parallel 64 -rf ./*.md5 "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
145+
rm -rf ./*.md5
146+
xrdcp --parallel 64 -rf ./ "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
147147
cd ..
148148
rm -r html
149-
xrdcp --parallel 64 -rf ./ ${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}
149+
xrdcp --parallel 64 -rf ./ "${EOS_ENDPOINT}/${EOS_BASE_PATH}/doc/${WEB_DIR_NAME}"
150150
cd ..
151-
xrdcp -rf ${TAR_FILE} ${EOS_ENDPOINT}/${EOS_BASE_PATH}/download
151+
xrdcp -rf "${TAR_FILE}" "${EOS_ENDPOINT}/${EOS_BASE_PATH}/download"

0 commit comments

Comments
 (0)