Skip to content

Commit b18bebf

Browse files
committed
[RF] Remove remnant setOperMode() in the RooFit::Evaluator constructor
Follows up on fa97774, which ensures that the mutation of the computation graphs operation mode is is only happening during minimization. There was a remnant `setOperMode(RooAbsArg::ADirty)` in the evaluator constructor that can now be removed.
1 parent 168b17e commit b18bebf

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

roofit/roofitcore/src/RooFit/Evaluator.cxx

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -326,17 +326,6 @@ void Evaluator::updateOutputSizes()
326326
for (auto &info : _nodes) {
327327
info.outputSize = outputSizeMap.at(info.absArg);
328328
info.isDirty = true;
329-
// We don't need dirty flag propagation because the evaluator takes care
330-
// of deciding what needs to be re-evaluated. We can disable the regular
331-
// dirty state propagation. However, fundamental variables like
332-
// RooRealVars and RooCategories are usually shared with other
333-
// computation graphs outside the evaluator, so they can't be mutated.
334-
// See also the code of the RooMinimizer, which ensures that dirty state
335-
// propagation is temporarily disabled during minimization to really
336-
// eliminate any overhead from the dirty flag propagation.
337-
if (!info.absArg->isFundamental()) {
338-
setOperMode(info.absArg, RooAbsArg::ADirty);
339-
}
340329
}
341330

342331
if (_useGPU) {

0 commit comments

Comments
 (0)