[cppyy] Newly enabled tests in ROOT by CppInterOp [ROOT-patch]

Author: aaronj0

bindings/pyroot/cppyy/cppyy/test/test_advancedcpp.py

@@ -770,15 +770,13 @@ def test23_using(self):
         assert d2.vcheck()  == 'A'
         assert d2.vcheck(1) == 'B'
 
-    @mark.xfail(strict=True)
     def test24_typedef_to_private_class(self):
         """Typedefs to private classes should not resolve"""
 
         import cppyy
 
         assert cppyy.gbl.TypedefToPrivateClass().f().m_val == 42
 
-    @mark.xfail(strict=True)
     def test25_ostream_printing(self):
         """Mapping of __str__ through operator<<(ostream&)"""
 
@@ -876,7 +874,6 @@ def test27_shadowed_typedef(self):
         #assert type(ns.A.Val(1)) == int
         #assert type(ns.B.Val(1)) == float
 
-    @mark.xfail(strict=True)
     def test28_extern_C_in_namespace(self):
         """Access to extern "C" declared functions in namespaces"""
 

bindings/pyroot/cppyy/cppyy/test/test_concurrent.py

@@ -22,7 +22,6 @@ def setup_class(cls):
 
         cppyy.gbl.Workers.calc.__release_gil__ = True
 
-    @mark.xfail(run=False, reason="Crashes because TClingCallFunc generates wrong code")
     def test01_simple_threads(self):
         """Run basic Python threads"""
 
@@ -41,7 +40,6 @@ def test01_simple_threads(self):
         for t in threads:
             t.join()
 
-    @mark.xfail(run=False, reason="Crashes because the interpreter emits too many warnings")
     def test02_futures(self):
         """Run with Python futures"""
 
@@ -262,7 +260,6 @@ def test():
         for t in threads:
             t.join()
 
-    @mark.xfail(run=False, reason="segmentation violation")
     def test07_overload_reuse_in_threads_wo_gil(self):
         """Threads reuse overload objects; check for clashes if no GIL"""
 

bindings/pyroot/cppyy/cppyy/test/test_cpp11features.py

@@ -300,7 +300,6 @@ def test08_initializer_list(self):
         for l in (['x'], ['x', 'y', 'z']):
             assert ns.foo(l) == std.vector['std::string'](l)
 
-    @mark.xfail(strict=True)
     def test09_lambda_calls(self):
         """Call (global) lambdas"""
 
@@ -357,7 +356,6 @@ def test11_chrono(self):
         # following used to fail with compilation error
         t = std.chrono.system_clock.now() + std.chrono.seconds(1)
 
-    @mark.xfail(strict=True)
     def test12_stdfunction(self):
         """Use of std::function with arguments in a namespace"""
 
@@ -545,7 +543,6 @@ def test18_unique_ptr_identity(self):
         p2 = c.pget()
         assert p1 is p2
 
-    @mark.xfail(strict=True)
     def test19_smartptr_from_callback(self):
         """Return a smart pointer from a callback"""
 

bindings/pyroot/cppyy/cppyy/test/test_crossinheritance.py

@@ -476,7 +476,6 @@ class MyPyDerived3(VD.MyClass3):
         class MyPyDerived4(VD.MyClass4[int]):
             pass
 
-    @mark.xfail(strict=True)
     def test14_protected_access(self):
         """Derived classes should have access to protected members"""
 
@@ -1021,7 +1020,6 @@ def return_const(self):
         assert a.return_const().m_value == "abcdef"
         assert ns.callit(a).m_value     == "abcdef"
 
-    @mark.xfail(strict=True)
     def test24_non_copyable(self):
         """Inheriting from a non-copyable base class"""
 
@@ -1779,7 +1777,6 @@ def f3(self):
         assert pysub.f3() == "Python: PySub::f3()"
         assert ns.call_fs(pysub) == pysub.f1() + pysub.f2() + pysub.f3()
 
-    @mark.xfail(strict=True)
     def test38_protected_data(self):
         """Multiple cross inheritance with protected data"""
 

bindings/pyroot/cppyy/cppyy/test/test_datatypes.py

@@ -25,7 +25,6 @@ def setup_class(cls):
         cls.datatypes = cppyy.load_reflection_info(cls.test_dct)
         cls.N = cppyy.gbl.N
 
-    @mark.xfail(strict=True)
     def test01_instance_data_read_access(self):
         """Read access to instance public data and verify values"""
 
@@ -196,7 +195,6 @@ def test01_instance_data_read_access(self):
 
         c.__destruct__()
 
-    @mark.xfail(strict=True)
     def test02_instance_data_write_access(self):
         """Test write access to instance public data and verify values"""
 
@@ -733,7 +731,6 @@ def test10_enum(self):
         assert gbl.EnumSpace.AA == 1
         assert gbl.EnumSpace.BB == 2
 
-    @mark.xfail(strict=True)
     def test11_typed_enums(self):
         """Determine correct types of enums"""
 
@@ -776,7 +773,6 @@ class Test {
         assert type(sc.vraioufaux.faux) == bool  # no bool as base class
         assert isinstance(sc.vraioufaux.faux, bool)
 
-    @mark.xfail(strict=True)
     def test12_enum_scopes(self):
         """Enum accessibility and scopes"""
 
@@ -1102,7 +1098,6 @@ def test21_object_validity(self):
 
         assert not d2
 
-    @mark.xfail(strict=True)
     def test22_buffer_shapes(self):
         """Correctness of declared buffer shapes"""
 
@@ -1266,7 +1261,7 @@ def run(self, f, buf, total):
         run(self, cppyy.gbl.sum_uc_data, buf, total)
         run(self, cppyy.gbl.sum_byte_data, buf, total)
 
-    @mark.xfail(strict=True, run=not IS_MAC and not IS_WINDOWS, reason="Fails on all platforms; crashes on macOS with " \
+    @mark.xfail(condition=IS_MAC, run=not IS_MAC and not IS_WINDOWS, reason="Fails on all platforms; crashes on macOS with " \
     "libc++abi: terminating due to uncaught exception")
     def test26_function_pointers(self):
         """Function pointer passing"""
@@ -1545,7 +1540,6 @@ def test30_multi_dim_arrays_of_builtins(test):
                 p = (ctype * len(buf)).from_buffer(buf)
                 assert [p[j] for j in range(width*height)] == [2*j for j in range(width*height)]
 
-    @mark.xfail(strict=True)
     def test31_anonymous_union(self):
         """Anonymous unions place there fields in the parent scope"""
 
@@ -1639,7 +1633,6 @@ def test31_anonymous_union(self):
         assert type(p.data_c[0]) == float
         assert p.intensity == 5.
 
-    @mark.xfail(strict=True)
     def test32_anonymous_struct(self):
         """Anonymous struct creates an unnamed type"""
 
@@ -1688,7 +1681,6 @@ class Foo2 {
 
         assert 'foo' in dir(ns.libuntitled1_ExportedSymbols().kotlin.root.com.justamouse.kmmdemo)
 
-    @mark.xfail(strict=True)
     def test33_pointer_to_array(self):
         """Usability of pointer to array"""
 
@@ -2049,7 +2041,6 @@ def test40_more_aggregates(self, capfd):
         output = (captured.out + captured.err).lower()
         assert "error:" not in output
 
-    @mark.xfail(strict=True)
     def test41_complex_numpy_arrays(self, capfd):
         """Usage of complex numpy arrays"""
 
@@ -2233,7 +2224,6 @@ def test45_const_ref_data(self):
         b = ns.B()
         assert b.body1.name == b.body2.name
 
-    @mark.xfail(strict=True)
     def test46_small_int_enums(self):
         """Proper typing of small int enums"""
 
@@ -2288,7 +2278,6 @@ def test46_small_int_enums(self):
         assert ns.func_int8()  == -1
         assert ns.func_uint8() == 255
 
-    @mark.xfail(strict=True)
     def test47_hidden_name_enum(self):
         """Usage of hidden name enum"""
 

bindings/pyroot/cppyy/cppyy/test/test_doc_features.py

@@ -1123,7 +1123,6 @@ def add(self, i):
 
         assert v.back().add(17) == 4+42+2*17
 
-    @mark.xfail(strict=True)
     def test_fallbacks(self):
         """Template instantation switches based on value sizes"""
 
@@ -1168,7 +1167,6 @@ def f(val):
         assert CC.callPtr(lambda i: 5*i, 4) == 20
         assert CC.callFun(lambda i: 6*i, 4) == 24
 
-    @mark.xfail(strict=True)
     def test_templated_callback(self):
         """Templated callback example"""
 

bindings/pyroot/cppyy/cppyy/test/test_eigen.py

@@ -100,7 +100,6 @@ def test02_comma_insertion(self):
         for i in range(5):
             assert v(i) == i+1
 
-    @mark.xfail(strict=True)
     def test03_matrices_and_vectors(self):
         """Matrices and vectors"""
 

bindings/pyroot/cppyy/cppyy/test/test_lowlevel.py

@@ -132,7 +132,6 @@ def test05_array_as_ref(self):
         f = array('f', [0]);     ctd.set_float_r(f);  assert f[0] ==  5.
         f = array('d', [0]);     ctd.set_double_r(f); assert f[0] == -5.
 
-    @mark.xfail(strict=True)
     def test06_ctypes_as_ref_and_ptr(self):
         """Use ctypes for pass-by-ref/ptr"""
 
@@ -489,7 +488,6 @@ def test14_templated_arrays(self):
         assert cppyy.gbl.std.vector[cppyy.gbl.std.vector[int]].value_type == 'std::vector<int>'
         assert cppyy.gbl.std.vector['int[1]'].value_type == 'int[1]'
 
-    @mark.xfail(strict=True)
     def test15_templated_arrays_gmpxx(self):
         """Use of gmpxx array types in templates"""
 

bindings/pyroot/cppyy/cppyy/test/test_numba.py

@@ -126,7 +126,6 @@ def go_fast(a):
         assert (go_fast(x) == go_slow(x)).all()
         assert self.compare(go_slow, go_fast, 300000, x)
 
-    @mark.xfail(strict=True)
     def test02_JITed_template_free_func(self):
         """Numba-JITing of Cling-JITed templated free function"""
 
@@ -281,7 +280,6 @@ def tma(x):
 
         assert sum == tma(x)
 
-    @mark.xfail(strict=True)
     def test07_datatype_mapping(self):
         """Numba-JITing of various data types"""
 
@@ -659,7 +657,8 @@ def np_dot_product(x, y):
         assert (njit_res == res)
         assert (time_njit < time_np)
 
-    @mark.skipif(eigen_path is None, reason="Eigen not found")
+    # @mark.skipif(eigen_path is None, reason="Eigen not found")
+    @mark.xfail(run=False, reason="Crashes with Transaction.cpp:98: void cling::Transaction::addNestedTransaction(cling::Transaction*): Assertion `!m_Unloading && 'Must not nest within unloading transaction' failed")
     def test14_eigen_numba(self):
         """Numba-JITing of a function that uses a cppyy declared Eigen Vector"""
 
@@ -743,7 +742,7 @@ def setup_class(cls):
         import cppyy
         import cppyy.numba_ext
 
-    @mark.xfail(strict=True)
+    @mark.xfail(strict=True, run=False, reason="Crashes with Transaction.cpp:98: void cling::Transaction::addNestedTransaction(cling::Transaction*): Assertion `!m_Unloading && 'Must not nest within unloading transaction' failed")
     def test01_templated_freefunction(self):
         """Numba support documentation example: free templated function"""
 
@@ -772,7 +771,8 @@ def tsa(a):
         assert type(tsa(a)) == int
         assert tsa(a) == 285
 
-    @mark.xfail(strict=True, condition=IS_WINDOWS, reason="Fails on Windows")
+    # @mark.xfail(strict=True, condition=IS_WINDOWS, reason="Fails on Windows")
+    @mark.xfail(strict=True, run=False, reason="Crashes with Transaction.cpp:98: void cling::Transaction::addNestedTransaction(cling::Transaction*): Assertion `!m_Unloading && 'Must not nest within unloading transaction' failed")
     def test02_class_features(self):
         """Numba support documentation example: class features"""
 

bindings/pyroot/cppyy/cppyy/test/test_operators.py

@@ -227,7 +227,6 @@ def test08_call_to_getsetitem_mapping(self):
             assert m[1]    == 74
             assert m(1,2)  == 74
 
-    @mark.xfail(strict=True, reason="Compilation of unused call wrappers emits errors")
     def test09_templated_operator(self, capfd):
         """Templated operator<()"""