[net] deprecate T*Socket::SetSecContext()

Author: jblomer

net/auth/src/TRootAuth.cxx

@@ -76,7 +76,7 @@ ROOT::Deprecated::TRootAuth::Authenticate(TSocket *s, const char *host, const ch
    } else {
       // Search pointer to relevant TSecContext
       ctx = auth->GetSecContext();
-      s->SetSecContext(ctx);
+      ROOT::Deprecated::TSocketFriend::SetSecContext(*s, ctx);
    }
    // Cleanup
    delete auth;

net/net/inc/TSocket.h

@@ -40,6 +40,7 @@ class TSocket;
 namespace ROOT::Deprecated {
 struct TSocketFriend {
    static Bool_t IsAuthenticated(const TSocket &s);
+   static void SetSecContext(TSocket &s, TSecContext *ctx);
 };
 } // namespace ROOT::Deprecated
 
@@ -163,7 +164,9 @@ friend class ROOT::Deprecated::TSocketFriend;
    void                  SetCompressionSettings(Int_t settings = ROOT::RCompressionSetting::EDefaults::kUseCompiledDefault);
    virtual Int_t         SetOption(ESockOptions opt, Int_t val);
    void                  SetRemoteProtocol(Int_t rproto) { fRemoteProtocol = rproto; }
-   void                  SetSecContext(ROOT::Deprecated::TSecContext *ctx) { fSecContext = ctx; }
+   void                  SetSecContext(ROOT::Deprecated::TSecContext *ctx)
+      R__DEPRECATED(6, 42, "TSocket::SetSecContext is deprecated")
+      { ROOT::Deprecated::TSocketFriend::SetSecContext(*this, ctx); }
    void                  SetService(const char *service) { fService = service; }
    void                  SetServType(Int_t st) { fServType = (EServiceType)st; }
    void                  SetUrl(const char *url) { fUrl = url; }

net/net/inc/TUDPSocket.h

@@ -135,7 +135,8 @@ friend class TServerSocket;
    void                  SetCompressionSettings(Int_t settings = ROOT::RCompressionSetting::EDefaults::kUseCompiledDefault);
    virtual Int_t         SetOption(ESockOptions opt, Int_t val);
    void                  SetRemoteProtocol(Int_t rproto) { fRemoteProtocol = rproto; }
-   void                  SetSecContext(ROOT::Deprecated::TSecContext *ctx) { fSecContext = ctx; }
+   void                  SetSecContext(ROOT::Deprecated::TSecContext *ctx)
+      R__DEPRECATED(6, 42, "TUDPSocket::SetSecContext is deprecated"){ fSecContext = ctx; }
    void                  SetService(const char *service) { fService = service; }
    void                  SetServType(Int_t st) { fServType = (EServiceType)st; }
    void                  SetUrl(const char *url) { fUrl = url; }

net/net/src/TPServerSocket.cxx

@@ -137,7 +137,7 @@ TPSocket *TPServerSocket::Accept(UChar_t Opt)
 
    // Transmit authentication information, if any
    if (ROOT::Deprecated::TSocketFriend::IsAuthenticated(*setupSocket))
-      newPSocket->SetSecContext(setupSocket->GetSecContext());
+      ROOT::Deprecated::TSocketFriend::SetSecContext(*newPSocket, setupSocket->GetSecContext());
 
    // clean up, if needed
    if (size > 0)

net/net/src/TSocket.cxx

@@ -41,6 +41,11 @@ Bool_t ROOT::Deprecated::TSocketFriend::IsAuthenticated(const TSocket &s)
    return s.fSecContext;
 }
 
+void ROOT::Deprecated::TSocketFriend::SetSecContext(TSocket &s, TSecContext *ctx)
+{
+   s.fSecContext = ctx;
+}
+
 
 ULong64_t TSocket::fgBytesSent = 0;
 ULong64_t TSocket::fgBytesRecv = 0;