Skip to content

Commit de06db7

Browse files
committed
[net] deprecate TS3HTTPRequest
1 parent 03b3541 commit de06db7

File tree

3 files changed

+19
-15
lines changed

3 files changed

+19
-15
lines changed

net/net/inc/LinkDef.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
#pragma link C++ class TParallelMergingFile+;
5656

5757
#ifdef R__SSL
58-
#pragma link C++ class TS3HTTPRequest+;
58+
#pragma link C++ class ROOT::Deprecated::TS3HTTPRequest+;
5959
#pragma link C++ class ROOT::Deprecated::TS3WebFile+;
6060
#pragma link C++ class TSSLSocket;
6161
#endif

net/net/inc/TS3HTTPRequest.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
#include "TString.h"
4242

43-
43+
namespace ROOT::Deprecated {
4444

4545
class TS3HTTPRequest : public TObject {
4646

@@ -160,4 +160,8 @@ inline TS3HTTPRequest& TS3HTTPRequest::SetSessionToken(const TString& token)
160160
return *this;
161161
}
162162

163+
} // namespace ROOT::Deprecated
164+
165+
using TS3HTTPRequest R__DEPRECATED(6, 42, "TS3HTTPRequest is deprecated") = ROOT::Deprecated::TS3HTTPRequest;
166+
163167
#endif

net/net/src/TS3HTTPRequest.cxx

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@
5353

5454
////////////////////////////////////////////////////////////////////////////////
5555

56-
TS3HTTPRequest::TS3HTTPRequest()
56+
ROOT::Deprecated::TS3HTTPRequest::TS3HTTPRequest()
5757
: fAuthType(kNoAuth), fHost("NoHost")
5858
{
5959
}
6060

6161
////////////////////////////////////////////////////////////////////////////////
6262
/// Default constructor
6363

64-
TS3HTTPRequest::TS3HTTPRequest(EHTTPVerb httpVerb, const TString& host,
64+
ROOT::Deprecated::TS3HTTPRequest::TS3HTTPRequest(EHTTPVerb httpVerb, const TString& host,
6565
const TString& bucket, const TString& objectKey, EAuthType authType,
6666
const TString& accessKey, const TString& secretKey)
6767
{
@@ -77,7 +77,7 @@ TS3HTTPRequest::TS3HTTPRequest(EHTTPVerb httpVerb, const TString& host,
7777
////////////////////////////////////////////////////////////////////////////////
7878
/// Copy constructor
7979

80-
TS3HTTPRequest::TS3HTTPRequest(const TS3HTTPRequest& r)
80+
ROOT::Deprecated::TS3HTTPRequest::TS3HTTPRequest(const TS3HTTPRequest& r)
8181
: TObject(r)
8282
{
8383
fVerb = r.fVerb;
@@ -93,7 +93,7 @@ TS3HTTPRequest::TS3HTTPRequest(const TS3HTTPRequest& r)
9393
////////////////////////////////////////////////////////////////////////////////
9494
/// Returns this request's signature
9595

96-
TString TS3HTTPRequest::ComputeSignature(TS3HTTPRequest::EHTTPVerb httpVerb) const
96+
TString ROOT::Deprecated::TS3HTTPRequest::ComputeSignature(TS3HTTPRequest::EHTTPVerb httpVerb) const
9797
{
9898
// Please note, the order of the fields used for computing
9999
// the signature is important. Make sure that the changes you
@@ -137,7 +137,7 @@ TString TS3HTTPRequest::ComputeSignature(TS3HTTPRequest::EHTTPVerb httpVerb) con
137137

138138
////////////////////////////////////////////////////////////////////////////////
139139

140-
TString TS3HTTPRequest::HTTPVerbToTString(TS3HTTPRequest::EHTTPVerb httpVerb) const
140+
TString ROOT::Deprecated::TS3HTTPRequest::HTTPVerbToTString(TS3HTTPRequest::EHTTPVerb httpVerb) const
141141
{
142142
switch (httpVerb) {
143143
case kGET: return TString("GET");
@@ -154,7 +154,7 @@ TString TS3HTTPRequest::HTTPVerbToTString(TS3HTTPRequest::EHTTPVerb httpVerb) co
154154
/// Sets this request's time stamp according to:
155155
/// http://code.google.com/apis/storage/docs/reference-headers.html#date
156156

157-
TS3HTTPRequest& TS3HTTPRequest::SetTimeStamp()
157+
ROOT::Deprecated::TS3HTTPRequest& ROOT::Deprecated::TS3HTTPRequest::SetTimeStamp()
158158
{
159159
time_t now = time(NULL);
160160
char result[128];
@@ -179,7 +179,7 @@ TS3HTTPRequest& TS3HTTPRequest::SetTimeStamp()
179179
/// will be of the form "GET /mybucket/path/to/my/file HTTP/1.1"
180180
/// Also note that the path must include the leading '/'.
181181

182-
TString TS3HTTPRequest::MakeRequestLine(TS3HTTPRequest::EHTTPVerb httpVerb) const
182+
TString ROOT::Deprecated::TS3HTTPRequest::MakeRequestLine(TS3HTTPRequest::EHTTPVerb httpVerb) const
183183
{
184184
return TString::Format("%s /%s%s HTTP/1.1",
185185
(const char*)HTTPVerbToTString(httpVerb),
@@ -190,23 +190,23 @@ TString TS3HTTPRequest::MakeRequestLine(TS3HTTPRequest::EHTTPVerb httpVerb) cons
190190
////////////////////////////////////////////////////////////////////////////////
191191
/// Returns the 'Host' header to include in the HTTP request.
192192

193-
TString TS3HTTPRequest::MakeHostHeader() const
193+
TString ROOT::Deprecated::TS3HTTPRequest::MakeHostHeader() const
194194
{
195195
return "Host: " + fHost;
196196
}
197197

198198
////////////////////////////////////////////////////////////////////////////////
199199
/// Returns the date header for this HTTP request
200200

201-
TString TS3HTTPRequest::MakeDateHeader() const
201+
TString ROOT::Deprecated::TS3HTTPRequest::MakeDateHeader() const
202202
{
203203
return "Date: " + fTimeStamp;
204204
}
205205

206206
////////////////////////////////////////////////////////////////////////////////
207207
/// Returns the session security token header for this HTTP request
208208

209-
TString TS3HTTPRequest::MakeTokenHeader() const
209+
TString ROOT::Deprecated::TS3HTTPRequest::MakeTokenHeader() const
210210
{
211211
if (fAuthType != kAmazon)
212212
return "";
@@ -221,7 +221,7 @@ TString TS3HTTPRequest::MakeTokenHeader() const
221221
////////////////////////////////////////////////////////////////////////////////
222222
/// Returns the authentication prefix
223223

224-
TString TS3HTTPRequest::MakeAuthPrefix() const
224+
TString ROOT::Deprecated::TS3HTTPRequest::MakeAuthPrefix() const
225225
{
226226
switch (fAuthType) {
227227
case kNoAuth: return "";
@@ -234,7 +234,7 @@ TString TS3HTTPRequest::MakeAuthPrefix() const
234234
////////////////////////////////////////////////////////////////////////////////
235235
/// Returns the authentication header for this HTTP request
236236

237-
TString TS3HTTPRequest::MakeAuthHeader(TS3HTTPRequest::EHTTPVerb httpVerb) const
237+
TString ROOT::Deprecated::TS3HTTPRequest::MakeAuthHeader(TS3HTTPRequest::EHTTPVerb httpVerb) const
238238
{
239239
if (fAuthType == kNoAuth)
240240
return "";
@@ -249,7 +249,7 @@ TString TS3HTTPRequest::MakeAuthHeader(TS3HTTPRequest::EHTTPVerb httpVerb) const
249249
////////////////////////////////////////////////////////////////////////////////
250250
/// Returns the HTTP request ready to be sent to the server
251251

252-
TString TS3HTTPRequest::GetRequest(TS3HTTPRequest::EHTTPVerb httpVerb, Bool_t appendCRLF)
252+
TString ROOT::Deprecated::TS3HTTPRequest::GetRequest(TS3HTTPRequest::EHTTPVerb httpVerb, Bool_t appendCRLF)
253253
{
254254
// Set time stamp before computing this request's signature. The signature
255255
// includes the date.

0 commit comments

Comments
 (0)