Skip to content

[roottest] convert to cmake meta/ROOT-7181 tests#19676

Closed
linev wants to merge 4 commits into
root-project:masterfrom
linev:roottest_meta_5
Closed

[roottest] convert to cmake meta/ROOT-7181 tests#19676
linev wants to merge 4 commits into
root-project:masterfrom
linev:roottest_meta_5

Conversation

@linev

@linev linev commented Aug 18, 2025

Copy link
Copy Markdown
Member

Like in cmsUnload, provide special runscript.C which loads commands and invoke them one by one.

Tests failing on most platforms with assert message from clang, to be investigated

@linev linev requested a review from pcanal August 18, 2025 12:40
@linev linev self-assigned this Aug 18, 2025
@linev linev requested review from bellenot and dpiparo as code owners August 18, 2025 12:40
@@ -1,5 +1,5 @@
.L lib/libjet.so
.L lib/libbtag.so
gSystem->Load("libjet_dictrflx");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious, why those changes?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, .so is not working on Windows.
And second - use of .L libjet_dictrflx requires changes of default macro path.
So I trying to load library with gSystem->Load.
Test perfectly works on my node, but fails on all CI nodes.
So I need to investigate further

@pcanal

pcanal commented Aug 18, 2025

Copy link
Copy Markdown
Member

Like in cmsUnload, provide special runscript.C which loads commands and invoke them one by one.

If that PR is already open and/or merged, can we link it here?

@github-actions

github-actions Bot commented Aug 18, 2025

Copy link
Copy Markdown

Test Results

    22 files      22 suites   4d 0h 42m 50s ⏱️
 3 789 tests  3 788 ✅  0 💤 1 ❌
81 401 runs  81 383 ✅ 16 💤 2 ❌

For more details on these failures, see this check.

Results for commit ff2e051.

♻️ This comment has been updated with latest results.

@linev

linev commented Aug 20, 2025

Copy link
Copy Markdown
Member Author

Like in cmsUnload, provide special runscript.C which loads commands and invoke them one by one.

If that PR is already open and/or merged, can we link it here?

Change of cmsUnload is here: #19672
But they do not depend from each other.
In both tests instead of redirecting of standard input one just read text file line by line and executing ProcessLine

@linev linev force-pushed the roottest_meta_5 branch 2 times, most recently from 505dc61 to c061944 Compare August 22, 2025 12:38
@linev linev force-pushed the roottest_meta_5 branch 2 times, most recently from e70cb3d to fddf5b4 Compare September 11, 2025 06:11
@linev linev marked this pull request as draft September 15, 2025 05:18
Like in cmsUnload, provide special runscript.C which loads commands
and invoke them one by one.
Use of ProcessLine does not work on CI nodes
add missing entries in dictionary and use fully-qualified template class

Actually it should not be required, by clang complains
@linev

linev commented Nov 14, 2025

Copy link
Copy Markdown
Member Author

Closing in favor of #20424

@linev linev closed this Nov 14, 2025
@linev linev deleted the roottest_meta_5 branch March 26, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants