Fix/tcolor preserve metadata#20046
Closed
aviralgarg05 wants to merge 2 commits into
Closed
Conversation
Test Results 22 files 22 suites 3d 22h 39m 47s ⏱️ For more details on these failures, see this check. Results for commit 104c3c9. ♻️ This comment has been updated with latest results. |
Member
|
Thanks for this code. In order to start the review we would need to also have a test that reproduces the problem. Notebook tests are in this directory https://github.com/root-project/root/tree/master/roottest/python/JupyROOT |
aviralgarg05
force-pushed
the
fix/tcolor-preserve-metadata
branch
from
a4fcac7 to
126b87a
Compare
vepadulano
reviewed
Oct 17, 2025
ferdymercury
reviewed
Nov 6, 2025
Author
|
I'll go through them and solve |
aviralgarg05
force-pushed
the
fix/tcolor-preserve-metadata
branch
from
30c8fe7 to
104c3c9
Compare
aviralgarg05
force-pushed
the
fix/tcolor-preserve-metadata
branch
from
104c3c9 to
8d65248
Compare
This fixes the Jupyter TColor.DefinedColors behavior. Closes root-project#20018.
Add notebook test and unit test to verify that TColor.__init__ metadata is preserved after pythonization. This ensures that introspection-heavy environments like Jupyter can properly inspect the method. * Add tcolor_definedcolors.ipynb: reproduces original issue root-project#20018 * Add test_tcolor_metadata.py: unit tests for metadata preservation * Update CMakeLists.txt: register notebook test in test suite This is a regression test for root-project#20018.
guitargeek
force-pushed
the
fix/tcolor-preserve-metadata
branch
from
8d65248 to
6796c40
Compare
Contributor
|
This was not the real fix. The actual fix is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #20018