[tmva][sofie] throw on invalid BatchNormalization input count#21773
Open
harz05 wants to merge 1 commit intoroot-project:masterfrom
Open
[tmva][sofie] throw on invalid BatchNormalization input count#21773harz05 wants to merge 1 commit intoroot-project:masterfrom
harz05 wants to merge 1 commit intoroot-project:masterfrom
Conversation
Contributor
Author
|
I'd also like to add a regression test for this(verifying Parse() throws std::runtime_error) but im not sure what's the best to add it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ParseBatchNormalizationonly constructed the operator wheninput_size() == 5but had noelseclause, so nodes with fewer inputs silently returned a nullunique_ptrand crashed later inGenerate()with an unrelated error message.I've simply added an
else throwto reject invalid input counts immediately at parse time with a clear error message, consistent with other parsers in the codebase.Checklist:
This PR fixes #21759