Open
Conversation
pcanal
reviewed
Apr 2, 2026
| return -1; | ||
| } | ||
| fref = new TWebFile(refFile); | ||
| fref = new ROOT::Deprecated::TWebFile(refFile); |
Member
There was a problem hiding this comment.
Suggested change
| fref = new ROOT::Deprecated::TWebFile(refFile); | |
| fref = TFile::Open(refFile); |
or is the use of TWebFile one of the point of the test?
pcanal
approved these changes
Apr 2, 2026
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
LGTM (with additional simplification in stressRooStats).
Test Results 22 files 22 suites 3d 5h 40m 32s ⏱️ Results for commit af717f9. ♻️ This comment has been updated with latest results. |
Contributor
|
The direct web file usage in |
jblomer
force-pushed
the
deprecate-webfile
branch
from
d1c36cb to
af717f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP remote I/O is also implemented in more modern ways in TDavixFile and TCurlFile.