[tmva][sofie] fix SAME_UPPER/SAME_LOWER autopad padding formula#21793
Open
harz05 wants to merge 1 commit intoroot-project:masterfrom
Open
[tmva][sofie] fix SAME_UPPER/SAME_LOWER autopad padding formula#21793harz05 wants to merge 1 commit intoroot-project:masterfrom
harz05 wants to merge 1 commit intoroot-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
The SAME_UPPER/SAME_LOWER autopad calculation in
ROperator_Conv.hxxandROperator_Pool.hxxwas usingkernel/2as a fixed pad value, ignoring input size and stride entirely. This gave wrong padding for any non-trivial case.Fixed to use the correct ONNX formula:
Also fixed the direction: SAME_UPPER should place the extra pad at the end, not the beginning (it was swapped earlier).
Also added regression tests for both
ConvWithAutopadSameLowerandConvWithAutopadSameUpper(kernel=3, stride=1 and stride=2 cases). Tests use odd-kernel models where padding is symmetric, since the existingIm2colutility only supports symmetric padding. Even-kernel SAME padding (asymmetric begin/end split) hits a separate pre-existing limitation inIm2coland I'll be adding that as an seperate issue.Checklist:
This PR fixes #21737