Enable fitpanel and stressgui tests with xvfb utitlity#22039
Merged
Conversation
Test Results 21 files 21 suites 3d 8h 39m 17s ⏱️ For more details on these failures, see this check. Results for commit 02d6039. ♻️ This comment has been updated with latest results. |
linev
changed the title
dpiparo
approved these changes
May 22, 2026
Do not automatically terminate application Use gSystem->RedirectOutput
To correctly run gui classes, gVirtualX->CreateGC should return every time unique value. Otherwise cleanup of many classes does not work correctly.
If xvfb-run detected on the system, use it to run stressGUI test. First create ref file and then check that it match. Prinout log information when generating ref file in stressGUI - otherwise missing info if something went wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable fitpanel and stressgui tests with
xvfb-runutility.It emulates X server and allows to run GUI tests on batch machines.
Also modernize fitpanel test to prepare for pure batch tests.
GUI classes requires that
gVirtualX->CreateGC()returns unique value. This id value identifyTGGCinstance and used to cleanup these instances at the end. If returned value always 0 - cleanup does not work correctly and may crash ROOT during teardown. In fitpanelUnitTestingprovide special subclass ofTVirtualXwhich returns unique ids. Maybe such workaround can be directly add to baseTVirtualXclass.Modernize
UnitTestingin fitpanel - usegSystem->RedirectOutputto redirect standard output to the file.