[io] Add buffer bound checks in TFile::Recover#22190
Merged
Merged
Conversation
silverweed
force-pushed
the
tfile_init_oob
branch
4 times, most recently
from
668624f to
33f969c
Compare
Test Results 22 files 22 suites 3d 13h 44m 3s ⏱️ Results for commit 5e6bdc2. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
May 12, 2026
pcanal
reviewed
May 18, 2026
silverweed
force-pushed
the
tfile_init_oob
branch
from
986cb8f to
5aa5f11
Compare
silverweed
force-pushed
the
tfile_init_oob
branch
from
5aa5f11 to
d93c4c9
Compare
This prevents potential oob stack reads in case of corrupted TFiles
- Declare variables when they're used - Spare a needless dynamic allocation - Use memcpy instead of frombuf in a loop
silverweed
force-pushed
the
tfile_init_oob
branch
from
d93c4c9 to
5e6bdc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
This PR fixes #22169