[http] reduce size of file.root request#22346
Merged
Merged
Conversation
bellenot
approved these changes
May 20, 2026
Test Results 22 files 22 suites 3d 15h 49m 2s ⏱️ For more details on these failures, see this check. Results for commit 41f622e. ♻️ This comment has been updated with latest results. |
Internally TMemFile is used - which has too large default block size. Set such default block size to 1024 bytes
All gtest macros like EXPECT_EQ can be supplied with output to explain that is checked. One than see such output in case of problem in log.
linev
force-pushed
the
http_get_file
branch
3 times, most recently
from
9dba1e7 to
41f622e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any object from
THttpServercan be requested withfile.rootrequestInternally
TMemFileused - which has very large default buffer size.Therefore default file size is 2MB - which is too much.
Reduce this to 1K, adjust already provided testing
Also add text output to
EXPECT_EQmacros - to get idea that value is compared.Simplify debugging afterwards