[ML][Python] Fix udnersampling test - rounding below min sampling ratio#22350
Merged
Conversation
vepadulano
approved these changes
May 20, 2026
Test Results 22 files 22 suites 3d 8h 9m 17s ⏱️ Results for commit 8d41f8c. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
test14_big_data_replacement_falsewas occasionally failing withinvalid_argument: The sampling_ratio is too lowbecauseround(uniform(min_allowed_sampling_ratio, 2), 2)could round the randomly generated ratio down belowmin_allowed_sampling_ratio. The fix makes sure to always round up so that the sampling ratio is always at or above the minimum valid value.Checklist: