Skip to content

[cppyy] Use cppdef for variable in test#22365

Merged
hahnjo merged 1 commit into
root-project:masterfrom
hahnjo:cppyy-fragile
May 21, 2026
Merged

[cppyy] Use cppdef for variable in test#22365
hahnjo merged 1 commit into
root-project:masterfrom
hahnjo:cppyy-fragile

Conversation

@hahnjo

@hahnjo hahnjo commented May 21, 2026

Copy link
Copy Markdown
Member

This fixes test22_cppexec which was marked as xfail if not IS_WINDOWS, which is the opposite of the given reason "Fails on Windows".

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

By the way, I think cppexec should work in principle, because it's the wrapper around gInterpreter->ProcessLine. And statements like gInterpreter->ProcessLine("int interactive_b = 4") do work in C++, so I don't see why they should not work in Python. You have any thoughts on this? I would like to understand what's going on there, to understand the interpreter better 🙂 Not a problem for this PR though, because it doesn't matter if we use cppexec or cppdef to implement the test for the interactive access to the Cling global scope.

@vepadulano

Copy link
Copy Markdown
Member

FWIW, I also don't understand why cppdef would be more correct than cppexec in this case

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 4h 53m 31s ⏱️
 3 854 tests  3 853 ✅ 0 💤 1 ❌
73 303 runs  73 302 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 2241db2.

♻️ This comment has been updated with latest results.

This fixes test22_cppexec which was marked as xfail if not IS_WINDOWS,
which is the opposite of the given reason "Fails on Windows".
@hahnjo hahnjo added the clean build Ask CI to do non-incremental build on PR label May 21, 2026
@hahnjo

hahnjo commented May 21, 2026

Copy link
Copy Markdown
Member Author

My understanding is that cppexec is to evaluate an expression. That's why I think cppdef is more appropriate here, and it seems to solve the issue with the test.

@hahnjo hahnjo merged commit 8efadfc into root-project:master May 21, 2026
28 of 33 checks passed
@hahnjo hahnjo deleted the cppyy-fragile branch May 21, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR in:Python Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants