[ntuple] Some cleanups in the page source#22391
Merged
Merged
Conversation
jblomer
force-pushed
the
ntuple-cleanup-loadpage
branch
from
5422338 to
26fff4b
Compare
pcanal
reviewed
May 23, 2026
pcanal
reviewed
May 23, 2026
Test Results 22 files 22 suites 3d 12h 35m 8s ⏱️ For more details on these failures, see this check. Results for commit a8107c2. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
May 25, 2026
jblomer
force-pushed
the
ntuple-cleanup-loadpage
branch
from
26fff4b to
de3fb29
Compare
The per-cluster/per-page OID mapping option was already unused (hard-coded). Going forward, the DAOS backend should only use the one-object-per-page option.
jblomer
force-pushed
the
ntuple-cleanup-loadpage
branch
from
de3fb29 to
a8107c2
Compare
silverweed
approved these changes
May 28, 2026
hahnjo
reviewed
Jun 1, 2026
Comment on lines
+414
to
+419
| if (pageInfo.GetLocator().GetType() == RNTupleLocator::kTypePageZero) { | ||
| assert(!pageInfo.HasChecksum()); | ||
| memcpy(const_cast<void *>(sealedPage.GetBuffer()), ROOT::Internal::RPage::GetPageZeroBuffer(), | ||
| sealedPage.GetBufferSize()); | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Why would we ever need to load a sealed zero page? According to the coverage information, this code is never executed...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for huge-file support, some cleanup in the
RPageSourcefamily of classes.There is more to improve, left for follow-up PRs.