[df] fix method call mistaken for column in Define()#22466
Merged
vepadulano merged 2 commits intoJun 3, 2026
Merged
Conversation
A method call on an object can share its name with a column. When that happens, the JIT expression becomes invalid and the Define() call throws a runtime error, even though the user's C++ is correct. Fixes root-project#22295
vepadulano
requested changes
Jun 3, 2026
vepadulano
left a comment
vepadulano
left a comment
Member
There was a problem hiding this comment.
Thank you for this PR! I have left minor comments to improve the test.
Use a non-zero sentinel value in the helper struct and add a value assertion so the test proves the correct method result is returned.
Test Results 22 files 22 suites 3d 12h 46m 2s ⏱️ Results for commit 63a66a3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A method call on an object can share its name with a column. When that happens, the JIT expression becomes invalid and the Define() call throws a runtime error, even though the user's C++ is correct.
Fixes #22295