Skip to content

[gtest] fix cppinterop testing with builtin_gtest#22469

Merged
linev merged 10 commits into
root-project:masterfrom
ferdymercury:patch-22
Jun 5, 2026
Merged

[gtest] fix cppinterop testing with builtin_gtest#22469
linev merged 10 commits into
root-project:masterfrom
ferdymercury:patch-22

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury requested a review from dpiparo June 3, 2026 10:15
@linev

linev commented Jun 3, 2026

Copy link
Copy Markdown
Member

Seems to be I got a glitch with incremental builds.

Now when I rebuild everything from scratch - cmake is happy.
Sorry for the noise

@linev linev closed this Jun 3, 2026
@ferdymercury ferdymercury deleted the patch-22 branch June 3, 2026 10:31
@ferdymercury ferdymercury restored the patch-22 branch June 3, 2026 11:21
@ferdymercury ferdymercury reopened this Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 11h 9m 33s ⏱️
 3 856 tests  3 856 ✅ 0 💤 0 ❌
77 072 runs  77 072 ✅ 0 💤 0 ❌

Results for commit 9db911d.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury requested a review from hageboeck June 3, 2026 11:24
@ferdymercury ferdymercury marked this pull request as ready for review June 3, 2026 11:24
@ferdymercury ferdymercury requested a review from bellenot as a code owner June 3, 2026 11:24
@ferdymercury ferdymercury changed the title [gtest] fix cppinterop testing [gtest] fix cppinterop testing with builtin_gtest Jun 3, 2026
@linev

linev commented Jun 3, 2026

Copy link
Copy Markdown
Member

Probably one need to do this like in ROOT_FIND_REQUIRED_DEP macro.
There error message is generated like:

   message(SEND_ERROR "The required package ${PACKAGE_NAME} was not found. "
   "Please install it in the system (preferred), set the corresponding CMake search variable, "
   "or opt in to downloading it using '-D${BUILTIN_CONFIG_OPTION}=ON'.")

Just let provide same kind of message for enabling builtin_gtest.

One just need to avoid that ffind_package(GTest) is invoked

@ferdymercury

ferdymercury commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

Probably one need to do this like in ROOT_FIND_REQUIRED_DEP macro.

Ok for me to add this, but I think it's a separate issue. There are many builtins that do not have yet this behavior, it's only for

# Request explicit user opt-in for required "easy to self-install" dependencies

Maybe all builtins considered easy should be enabled at one, not just gtest.

@linev

linev commented Jun 3, 2026

Copy link
Copy Markdown
Member

gtest and gmock are really available on all platforms.
So making error like for other common builtins should be ok.

@linev

linev commented Jun 3, 2026

Copy link
Copy Markdown
Member

Your second commit goes in right direction.
But one need to remove related code from lines 1270..1300
And in macro ROOT_FIND_REQUIRED_DEP one should be able to provide version of GTest

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

But one need to remove related code from lines 1270..1300
And in macro ROOT_FIND_REQUIRED_DEP one should be able to provide version of GTest

Done!

@ferdymercury ferdymercury requested a review from linev June 3, 2026 18:13

@linev linev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@linev linev merged commit af04fd2 into root-project:master Jun 5, 2026
57 of 58 checks passed
@ferdymercury ferdymercury deleted the patch-22 branch June 5, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants