Skip to content

[6.36] [core] print URL to terminal if web browser could not be opened #22506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 1 commit into from
Jun 7, 2026
Merged

[6.36] [core] print URL to terminal if web browser could not be opened #22506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions core/base/src/TApplication.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,8 @@ TApplication::EExitOnException TApplication::ExitOnException(TApplication::EExit
/// The function generates and executes a command that loads the Doxygen URL in
/// a browser. It works for Mac, Windows and Linux. In the case of Linux, the
/// function also checks if the DISPLAY is set. If it isn't, a warning message
/// and the URL will be displayed on the terminal.
/// and the URL will be displayed on the terminal. In all OS, if the system command
/// fails, the URL will be also displayed on the terminal.
///
/// \param[in] url web page to be displayed in a browser

Expand All @@ -634,26 +635,28 @@ void TApplication::OpenInBrowser(const TString &url)
TString cMac("open ");
// We generate the full command and execute it.
cMac.Append(url);
gSystem->Exec(cMac);
auto res = gSystem->Exec(cMac);
#elif defined(R__WIN32)
// Command for opening a browser on Windows.
TString cWindows("start \"\" ");
cWindows.Append(url);
gSystem->Exec(cWindows);
auto res = gSystem->Exec(cWindows);
#else
// Command for opening a browser in Linux.
// For Linux we check first if the DISPLAY is set.
if (!gSystem->Getenv("DISPLAY")) {
// The user will have a warning and the URL in the terminal.
Warning("OpenInBrowser", "The $DISPLAY is not set! Please manually open (e.g. Ctrl-click) %s\n", url.Data());
return;
}
// Command for opening a browser in Linux. Since the DISPLAY is set, it will open the browser.
TString cLinux("xdg-open ");
// For Linux we check if the DISPLAY is set.
if (gSystem->Getenv("DISPLAY")) {
// If the DISPLAY is set it will open the browser.
cLinux.Append(url);
gSystem->Exec(cLinux);
} else {
// Else the user will have a warning and the URL in the terminal.
Warning("OpenInBrowser", "The $DISPLAY is not set! Please open (e.g. Ctrl-click) %s\n", url.Data());
cLinux.Append(url);
auto res = gSystem->Exec(cLinux);
#endif
if (res != EXIT_SUCCESS) {
Warning("OpenInBrowser", "Could not automatically open web browser (e.g. due to missing X11)! Please manually open (e.g. Ctrl-click) %s\n", url.Data());
return;
}
#endif
Info("OpenInBrowser", "A new tab should have opened in your browser.");
}

Expand Down
Loading