Skip to content

[Python] Do not fall back to the GIL on free-threaded Python #22548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guitargeek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Python] Do not fall back to the GIL on free-threaded Python #22548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bindings/pyroot/cppyy/CPyCppyy/src/CPyCppyyModule.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
#if PY_VERSION_HEX >= 0x030d0000
, 0 // tp_versions_used
#endif
};

Check warning on line 180 in bindings/pyroot/cppyy/CPyCppyy/src/CPyCppyyModule.cxx

View workflow job for this annotation

GitHub Actions / rawhide Fedora pydebug no GIL CMAKE_CXX_STANDARD=23 

missing initializer for member ‘_typeobject::_tp_iteritem’ [-Wmissing-field-initializers]


static PyObject* default_repr(PyObject*)
Expand Down Expand Up @@ -224,7 +224,7 @@
#if PY_VERSION_HEX >= 0x030d0000
, 0 // tp_versions_used
#endif
};

Check warning on line 227 in bindings/pyroot/cppyy/CPyCppyy/src/CPyCppyyModule.cxx

View workflow job for this annotation

GitHub Actions / rawhide Fedora pydebug no GIL CMAKE_CXX_STANDARD=23 

missing initializer for member ‘_typeobject::_tp_iteritem’ [-Wmissing-field-initializers]

namespace {

Expand Down Expand Up @@ -1192,6 +1192,11 @@

#if PY_VERSION_HEX >= 0x03000000
Py_INCREF(gThisModule);
#endif
// Avoid fallback to the GIL when importing this module in a free-threaded
// Python build.
#ifdef Py_GIL_DISABLED
PyUnstable_Module_SetGIL(gThisModule, Py_MOD_GIL_NOT_USED);
#endif
return gThisModule;
}
Expand Down
5 changes: 5 additions & 0 deletions bindings/pyroot/pythonizations/src/PyROOTModule.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,5 +259,10 @@ extern "C" PyObject *PyInit_libROOTPythonizations()
// keep gRootModule, but do not increase its reference count even as it is borrowed,
// or a self-referencing cycle would be created

// Avoid fallback to the GIL when importing this module in a free-threaded
// Python build.
#ifdef Py_GIL_DISABLED
PyUnstable_Module_SetGIL(gRootModule, Py_MOD_GIL_NOT_USED);
#endif
return gRootModule;
}
Loading