[main] Add --abort-on-failure flag to rootcp and some sanity checks#22555
Merged
Conversation
vepadulano
requested changes
Jun 10, 2026
vepadulano
left a comment
vepadulano
left a comment
Member
There was a problem hiding this comment.
I like the idea! I left a couple of minor suggestions, also a test would be nice to have.
silverweed
force-pushed
the
rootcp_strict
branch
from
22a1703 to
408bcbc
Compare
Test Results 22 files 22 suites 3d 13h 23m 36s ⏱️ For more details on these failures, see this check. Results for commit d87406c. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Jun 11, 2026
pcanal
reviewed
Jun 11, 2026
Otherwise it may fail to run if the file is already there
silverweed
force-pushed
the
rootcp_strict
branch
from
408bcbc to
d87406c
Compare
silverweed
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the option to abort the entire copy if any object fails to be copied.