Skip to content

[webgui] improve TMethodCall usage #22556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linev merged 1 commit into from
Jun 10, 2026
Merged

[webgui] improve TMethodCall usage #22556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions graf2d/gpadv7/src/TObjectDrawable.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,21 @@ using namespace ROOT::Experimental;
void TObjectDrawable::CheckOwnership(TObject *obj)
{
if (obj && obj->InheritsFrom("TH1")) {
TMethodCall call(obj->IsA(), "SetDirectory", "nullptr");
call.Execute((void *)(obj));
TMethodCall call;
call.InitWithPrototype(obj->IsA(), "SetDirectory", "TDirectory*");
if (call.IsValid()) {
void *arg0 = nullptr;
const void *method_args[1] = { &arg0 };
call.Execute((void *) obj, method_args, 1);
}
} else if (obj && obj->InheritsFrom("TF1")) {
TMethodCall call(obj->IsA(), "AddToGlobalList", "kFALSE");
call.Execute((void *)(obj));
TMethodCall call;
call.InitWithPrototype(obj->IsA(), "AddToGlobalList", "Bool_t");
if (call.IsValid()) {
Bool_t arg0 = kFALSE;
const void *method_args[1] = { &arg0 };
call.Execute((void *) obj, method_args, 1);
}
}
}

Expand Down
16 changes: 4 additions & 12 deletions gui/webgui6/src/TWebMenuItem.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,20 +83,12 @@ void TWebMenuItems::PopulateObjectMenu(void *obj, TClass *cl)

if ((getter.Length() > 0) && cl->GetMethodAllAny(getter)) {
// execute getter method to get current state of toggle item

TMethodCall *call = new TMethodCall(cl, getter, "");

if (call->ReturnType() == TMethodCall::kLong) {
Longptr_t l(0);
call->Execute(obj, l);

TMethodCall call(cl, getter, "");
if (call.ReturnType() == TMethodCall::kLong) {
Longptr_t l = 0;
call.Execute(obj, l);
AddChkMenuItem(m->GetName(), m->GetTitle(), l != 0, TString::Format("%s(%s)", m->GetName(), (l != 0) ? "0" : "1").Data(), m->GetClass());

} else {
// Error("CheckModifiedFlag", "Cannot get toggle value with getter %s", getter.Data());
}

delete call;
}
} else {
TList *args = m->GetListOfMethodArgs();
Expand Down
Loading