[6.40] [RF][HS3] Significantly speed up JSON import of large models#22580
Merged
guitargeek merged 3 commits intoJun 11, 2026
Merged
Conversation
This speeds up the workspace factory language if the same constructors are used repeatedly, which is quite common when models are built programmatically. (cherry picked from commit a0c799b)
Fast-path importers for RooProduct, RooAddition, and RooProdPdf that bypass the generic factory-expression mechanism, which is quite expensive because it uses the interpreter. This dramatically speeds up the import of models from JSON that use instances of these common classes in large numbers. (cherry picked from commit fbf5e87)
Looking up by name in the JSON tree is quite slow and happens often during model import from JSON. Caching the pointers to the JSON nodes corresponding to the RooAbsArgs (distributions and functions) speeds up JSON import significantly. (cherry picked from commit 149cca4)
guitargeek
merged commit 1a594a3
into
root-project:v6-40-00-patches
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22502, requested by @guitargeek.