[6.40] [HS3] Add parameter errors in HS3 JSON import/export#22585
Merged
guitargeek merged 1 commit intoJun 12, 2026
Merged
Conversation
This PR adds support for exporting and importing RooRealVar parameter errors through HS3 JSON. Parameter uncertainties are written to misc.minimization.parameter_stepwidths and restored during import after the default parameter snapshot is loaded. The export logic collects relevant parameters from ModelConfig POI/nuisance sets and from PDF/data fallback discovery, while excluding observables and data axes. The PR also adds regression coverage for parameter-error round-tripping, data-axis exclusion, and preserving imported errors together with default snapshot values. (cherry picked from commit 283b12f)
Test Results 21 files 21 suites 3d 5h 16m 37s ⏱️ Results for commit 883c805. |
guitargeek
merged commit 30b78d4
into
root-project:v6-40-00-patches
33 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22405, requested by @guitargeek. For your information @Phmonski