[6.40] [tree] Fix long64 tree index losing precision on 64-bit long double platforms and enable forgotten test#22607
Merged
guitargeek merged 2 commits intoJun 15, 2026
Conversation
(cherry picked from commit 4a5eca1)
…latforms The conditional `long64major ? GetLong64() : GetAndRangeCheck()` mixes Long64_t and LongDouble_t, so the exact value was promoted through long double regardless of branch. This rounded large values where long double is 64-bit (macOS arm64, Windows), making roottest-root-tree-index-indexl64 fail there while passing on Linux. Fix this with an explicit `static_cast<Long64_t>(ret)`. 🤖 Done with the help of [Claude Code](https://claude.com/claude-code) (Claude Opus 4.8) (cherry picked from commit d9fae25)
root-project-bot
requested review from
bellenot,
dpiparo and
pcanal
as code owners
Test Results 21 files 21 suites 3d 6h 18m 21s ⏱️ Results for commit b7703a7. |
guitargeek
merged commit ab729c1
into
root-project:v6-40-00-patches
33 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #19741, requested by @guitargeek. For your information @ferdymercury