[RF] Fix various memory leaks caused by not deleting return values#22663
Merged
Conversation
Fix various memory leaks from cases where functions that return an owned return value were used without deleting the return value. This is addressed by using `std::unique_ptr`.
Test Results 21 files 21 suites 3d 7h 16m 59s ⏱️ Results for commit c74131f. |
lmoneta
approved these changes
Jun 19, 2026
lmoneta
left a comment
lmoneta
left a comment
Member
There was a problem hiding this comment.
LGTM! Thank you for fixing these memory leaks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various memory leaks from cases where functions that return an owned return value were used without deleting the return value.
This is addressed by using
std::unique_ptr.