[ntuple] Streamline RPageSource class hierarchy#22681
Open
jblomer wants to merge 5 commits into
Open
Conversation
jblomer
force-pushed
the
ntuple-cgcb
branch
2 times, most recently
from
b0570d5 to
b651605
Compare
Make use of the dedicated callback that loads the compressed header and footer, instead of leaving it squashed in AttachImpl().
A new callback that loads a particular page list from the backend storage. As a result, the logic to load the page lists and to populate the cluster group descriptor has been moved from the concrete page source implementations to the RPageSource base class. Moving on, this will allow to decouple loading the page lists from attaching the storage.
Test Results 22 files 22 suites 3d 14h 19m 16s ⏱️ For more details on these failures, see this check. Results for commit b651605. |
silverweed
reviewed
Jun 23, 2026
| virtual void UnzipClusterImpl(ROOT::Internal::RCluster *cluster); | ||
| // Loads a page list into the provided buffer. The buffer parameter needs to point to a memory region large enough | ||
| // to hold the compressed page list. | ||
| virtual void LoadPageListImpl(const RNTupleLocator &locator, void *buffer) = 0; |
Contributor
There was a problem hiding this comment.
Should we also pass the buffer size, to validate the requirement stated by the comment?
Also, since the buffer will be treated as a blob of bytes both by the caller and the callee, maybe we can mark it as a std::byte * for convenience...(similarly to the Serializer functions that use unsigned char; in fact, even though byte is better in principle we might still want to use unsigned char for consistency)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further streamlining of the page source in preparation of huge file support.
LoadStructureImpl()for the DAOS page sourceRPageSource::LoadPageListImpl()abstract method so that concrete page sources don't need to populate the cluster group descriptor themselves but they only need to know how to load a page list.