[net] Restore TGrid* classes#22874
Merged
Merged
Conversation
silverweed
added
the
experiment
jblomer
previously requested changes
Jul 21, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
In v6.40, these classes are available, they are just deprecated.
A possible alternative, for the time being, is restoring these classes with a farther removal target to give us more time to discuss.
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 2d47cab. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
Jul 22, 2026
jblomer
reviewed
Jul 22, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
In v6.40, these classes are available, they are just deprecated.
A possible alternative, for the time being, is restoring these classes with a farther removal target to give us more time to discuss.
silverweed
force-pushed
the
tgrid_undeprecate
branch
from
July 24, 2026 13:23
7ff595c to
2d47cab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ALICE experiment depends critically on these classes so they cannot be removed for the time being.
This PR restores them to their non-deprecated status.
Likely needs backporting to 6.40.
cc @ktf