fix TStreamerLoop counter offset in member-wise streaming#22901
fix TStreamerLoop counter offset in member-wise streaming#22901tamasgal wants to merge 9 commits into
Conversation
|
Thanks for this proposal. Just to double-check: have you had a moment to give a look to ROOT's contributing policy? https://github.com/root-project/root/blob/master/CONTRIBUTING.md#ai-assisted-coding-disclosure |
|
no LLM involved, only tooling were clang-format and my ROOT binary reverse engineering skills from the past years |
|
many thanks for the comments! Meanwhile me and my colleague (with more that two decades of ROOT experience and the original author of our I/O library) are still doing tests and found other issues, so let me put this on hold for now. I'll implement your suggestions of course but I fear it's not the whole story |
Co-authored-by: Jakob Blomer <jblomer@cern.ch>
Co-authored-by: Jakob Blomer <jblomer@cern.ch>
|
as mentioned in the upstream issue, we verified the patch also with the extensive high-level test suite, everything looks fine from our side |
Thanks for the clarification! I restarted the tests with the newly proposed code. |
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 41d95f7. |
This Pull request:
Fixes TStreamerLoop counter offset in member-wise streaming and adds a regression test.
Changes or fixes:
Checklist:
This PR fixes #22895