Skip to content

Commit f4e77f8

Browse files
committed
Snapshot does not need template args now
1 parent 349f8de commit f4e77f8

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

root/io/io/TFile_RDFSnapshot.cxx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ static void BM_TFile_RDFSnapshot_ZLIB(benchmark::State &state) {
2828
auto options = SetupRDFOptions(ROOT::RCompressionSetting::EAlgorithm::kZLIB, 1);
2929
for (auto _ : state) {
3030
//And we write out the dataset on disk
31-
tdf.Snapshot<double>("randomNumbers", "bench_data.root", {"rnd"}, options);
31+
tdf.Snapshot("randomNumbers", "bench_data.root", {"rnd"}, options);
3232
}
3333
}
3434
BENCHMARK(BM_TFile_RDFSnapshot_ZLIB)->Unit(benchmark::kMicrosecond);
@@ -39,7 +39,7 @@ static void BM_TFile_RDFSnapshot_LZ4(benchmark::State &state) {
3939
auto options = SetupRDFOptions(ROOT::RCompressionSetting::EAlgorithm::kLZ4, 4);
4040
for (auto _ : state) {
4141
//And we write out the dataset on disk
42-
tdf.Snapshot<double>("randomNumbers", "bench_data.root", {"rnd"}, options);
42+
tdf.Snapshot("randomNumbers", "bench_data.root", {"rnd"}, options);
4343
}
4444
}
4545
BENCHMARK(BM_TFile_RDFSnapshot_LZ4)->Unit(benchmark::kMicrosecond);
@@ -50,7 +50,7 @@ static void BM_TFile_RDFSnapshot_LZMA (benchmark::State &state) {
5050
auto options = SetupRDFOptions(ROOT::RCompressionSetting::EAlgorithm::kLZMA, 8);
5151
for (auto _ : state) {
5252
//And we write out the dataset on disk
53-
tdf.Snapshot<double>("randomNumbers", "bench_data.root", {"rnd"}, options);
53+
tdf.Snapshot("randomNumbers", "bench_data.root", {"rnd"}, options);
5454
}
5555
}
5656
BENCHMARK(BM_TFile_RDFSnapshot_LZMA)->Unit(benchmark::kMicrosecond);
@@ -60,7 +60,7 @@ static void BM_TFile_RDFSnapshot_ZSTD (benchmark::State &state) {
6060
auto options = SetupRDFOptions(ROOT::RCompressionSetting::EAlgorithm::kZSTD, 6);
6161
for (auto _ : state) {
6262
//And we write out the dataset on disk
63-
tdf.Snapshot<double>("randomNumbers", "bench_data.root", {"rnd"}, options);
63+
tdf.Snapshot("randomNumbers", "bench_data.root", {"rnd"}, options);
6464
}
6565
}
6666
BENCHMARK(BM_TFile_RDFSnapshot_ZSTD)->Unit(benchmark::kMicrosecond);

root/tree/dataframe/RDataFrameBenchmarks.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ static void BM_RDataFrame_CreateFromFile(benchmark::State &state)
2020
{
2121
const auto fname = RB::GetTempFs() + "/tdf_createfromfile.root";
2222
const auto treeName = "t";
23-
RDataFrame(0).Snapshot<>(treeName, fname, {});
23+
RDataFrame(0).Snapshot(treeName, fname, {});
2424

2525
for (auto _ : state)
2626
RDataFrame(treeName, fname);
@@ -84,7 +84,7 @@ static void BM_RDataFrame_NoOpLoopOnFile(benchmark::State &state)
8484
{
8585
const auto fname = RB::GetTempFs() + "/tdf_nooplooponfile" + std::to_string(state.range(0)) + ".root";
8686
const auto treeName = "t";
87-
RDataFrame(state.range(0)).Snapshot<>(treeName, fname, {});
87+
RDataFrame(state.range(0)).Snapshot(treeName, fname, {});
8888

8989
for (auto _ : state)
9090
RDataFrame(treeName, fname).Foreach([] {});

root/tree/dataframe/RDataFrameSumBenchmarks.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ void MakeDataIfNeeded()
3232
ROOT::RDataFrame(nEntries)
3333
.Define(scalarBranch, [] { return 42; })
3434
.Define(vectorBranch, [] { return std::vector<int>{1, 2, 3, 4, 5, 6, 7, 8}; })
35-
.Snapshot<int, std::vector<int>>(treeName, pathToFile.c_str(), {scalarBranch, vectorBranch});
35+
.Snapshot(treeName, pathToFile.c_str(), {scalarBranch, vectorBranch});
3636
}
3737

3838
static void BM_RDataFrameSum_CreateEmptyDF(benchmark::State &state)

0 commit comments

Comments
 (0)