Merge pull request #34 from rootlyhq/fix/entity-kind-guard

[bug]: Fix Entity Kind Guard

Author: Hchanni

.yarn/install-state.gz

@@ -1,5 +1,12 @@
 # @rootly/backstage-plugin-entity-processor
 
+## 1.3.1
+
+- Add entity kind guards to prevent wrong-kind annotations from corrupting Rootly resources
+- `rootly.com/team-id` and `rootly.com/team-slug` annotations are now only processed for `kind: Group` entities
+- `rootly.com/service-id` and `rootly.com/service-slug` annotations are now only processed for `kind: Component` entities
+- Pre-existing wrong-kind annotations (e.g. a Component carrying `rootly.com/team-slug`) become silent no-ops after upgrading
+
 ## 1.3.0
 
 - Add catalog entity processing support

CHANGELOG.md

@@ -1,7 +1,7 @@
 {
   "name": "@rootly/backstage-plugin-entity-processor",
   "description": "Rootly Catalog processor Backstage",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "main": "dist/index.cjs.js",
   "types": "dist/index.d.ts",
   "license": "MIT",

dist/module.cjs.js.map

@@ -176,7 +176,7 @@ export class RootlyEntityProcessor implements CatalogProcessor {
         config: this.config,
         organizationId: organizationId,
       });
-      if (this.serviceIdAnnotations(entity)) {
+      if (this.serviceIdAnnotations(entity) && entity.kind === 'Component') {
         return this.processRootlyService(
           rootlyClient,
           organizationId,
@@ -192,7 +192,7 @@ export class RootlyEntityProcessor implements CatalogProcessor {
           location,
           emit,
         );
-      } else if (this.teamIdAnnotations(entity)) {
+      } else if (this.teamIdAnnotations(entity) && entity.kind === 'Group') {
         return this.processRootlyTeam(
           rootlyClient,
           organizationId,