Add owner_group_ids to heartbeat create/update models#10
Closed
linear-code[bot] wants to merge 1 commit into
Closed
Add owner_group_ids to heartbeat create/update models#10linear-code[bot] wants to merge 1 commit into
linear-code[bot] wants to merge 1 commit into
Conversation
Adds the owner_group_ids field to NewHeartbeatDataAttributes and UpdateHeartbeatDataAttributes so team-scoped API keys can create and update team-owned heartbeats through the SDK. The public OpenAPI spec already exposes this field on the heartbeat create/update schemas; the generated models had not been regenerated to include it. Generated with [Linear](https://linear.app/rootly/issue/IR-5978/rootly-python-newupdate-heartbeat-schema-missing-owner-group-ids#agent-session-ecdd5403) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
2 tasks
Member
|
Superseded by #11 — full client regeneration from latest OpenAPI spec includes owner_group_ids. |
kwent
added a commit
that referenced
this pull request
Jul 21, 2026
* Regenerate client from latest OpenAPI spec Supersedes #10 (owner_group_ids on heartbeat models) — that field is now included via the full regeneration. * Add v1.4.0 changelog and fix pyproject.toml version Generator overwrote version to "v1" — restored to 1.4.0. Also restored CHANGELOG.md in package includes. * Add .serena/ to .gitignore and remove from tracking * Fix ruff lint errors in generated SDK code Auto-fix 23051 errors: unused imports (F401), import sorting (I001), and deprecated type annotations (UP). * Add ruff check --fix step to Makefile regenerate target * Fix ruff formatting for entire rootly_sdk/ directory Previous commit only formatted models/ subdirectory, missing api/, client.py, errors.py, and types.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
owner_group_idsfield toNewHeartbeatDataAttributesandUpdateHeartbeatDataAttributesso team-scoped API keys can create and update team-owned heartbeats through the SDK. Without it,POST /v1/heartbeatswith a team-scoped key fails (404) and callers have to drop to raw HTTP or use a global key.The public OpenAPI spec already exposes
owner_group_idson both heartbeat schemas (list[str], "List of team IDs that own this heartbeat"); the generated models just hadn't been regenerated to include it. This change matches exactly what the generator emits for a non-nullable string-array field (as seen on e.g.EscalationPolicy.group_ids), inserted in spec order — afteralert_urgency_id/notification_target_type, beforeenabled.Verified
to_dict()/from_dict()round-trip the field and that it stays out of the payload when unset.