Lint issues#107
Merged
Merged
Conversation
agustinkoll-rootstrap
requested review from
amaury901130,
juanRodriguez17 and
tarruk
tarruk
approved these changes
Oct 2, 2025
| width: width, | ||
| height: height, | ||
| color: svgIconColor, | ||
| colorFilter: color != null ? ColorFilter.mode(svgIconColor!, BlendMode.srcIn) : null, |
Contributor
There was a problem hiding this comment.
Suggested change
| colorFilter: color != null ? ColorFilter.mode(svgIconColor!, BlendMode.srcIn) : null, | |
| colorFilter: color != null ? ColorFilter.mode(svgIconColor!, BlendMode.srcIn,) : null, |
| height: height, | ||
| fit: fit, | ||
| color: color, | ||
| colorFilter: color != null ? ColorFilter.mode(color, BlendMode.srcIn) : null, |
Contributor
There was a problem hiding this comment.
Suggested change
| colorFilter: color != null ? ColorFilter.mode(color, BlendMode.srcIn) : null, | |
| colorFilter: color != null ? ColorFilter.mode(color, BlendMode.srcIn,) : null, |
|
|
||
| const FailureWidget({Key? key, required this.failure, required this.onRetry}) | ||
| : super(key: key); | ||
| const FailureWidget({super.key, required this.failure, required this.onRetry}); |
Contributor
There was a problem hiding this comment.
Suggested change
| const FailureWidget({super.key, required this.failure, required this.onRetry}); | |
| const FailureWidget({super.key, required this.failure, required this.onRetry,}); |
|
|
||
| const ConnectionErrorWidget({Key? key, required this.onRetry}) | ||
| : super(key: key); | ||
| const ConnectionErrorWidget({super.key, required this.onRetry}); |
Contributor
There was a problem hiding this comment.
Suggested change
| const ConnectionErrorWidget({super.key, required this.onRetry}); | |
| const ConnectionErrorWidget({super.key, required this.onRetry,}); |
|
|
||
| const UnexpectedErrorWidget({Key? key, required this.onRetry}) | ||
| : super(key: key); | ||
| const UnexpectedErrorWidget({super.key, required this.onRetry}); |
Contributor
There was a problem hiding this comment.
Suggested change
| const UnexpectedErrorWidget({super.key, required this.onRetry}); | |
| const UnexpectedErrorWidget({super.key, required this.onRetry,}); |
| final Product product; | ||
|
|
||
| const ProductWidget({Key? key, required this.product}) : super(key: key); | ||
| const ProductWidget({super.key, required this.product}); |
Contributor
There was a problem hiding this comment.
Suggested change
| const ProductWidget({super.key, required this.product}); | |
| const ProductWidget({super.key, required this.product,}); |
| final List<Product> products; | ||
|
|
||
| const ProductsListWidget({Key? key, required this.products}) : super(key: key); | ||
| const ProductsListWidget({super.key, required this.products}); |
Contributor
There was a problem hiding this comment.
Suggested change
| const ProductsListWidget({super.key, required this.products}); | |
| const ProductsListWidget({super.key, required this.products,}); |
| static void initialize() { | ||
| // Initialize analytics services here | ||
| print("Analytics services initialized."); | ||
| developer.log('Analytics services initialized.', name: 'analytics'); |
Contributor
There was a problem hiding this comment.
Suggested change
| developer.log('Analytics services initialized.', name: 'analytics'); | |
| developer.log('Analytics services initialized.', name: 'analytics',); |
juanRodriguez17
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolved all lints until
flutter analyzereports no issues.Removed IDE artifacts by deleting
.idea/from VCS and adding it to .gitignore. Added additional ignores for common local/dev files.Replaced deprecated Flutter/Dart parameters/APIs with current equivalents to align with latest stable SDKs.
Issue
Preview
Notes:
[extra note or considerations]
@rs-gpt-review Describe the changes in this PR. Recommend improvements (including code improvements), possible memory leaks, and best practices.