From 2f8dddcdda1599e116bcafdced43f0bd55507fc0 Mon Sep 17 00:00:00 2001 From: Fernanda Toledo Date: Fri, 16 May 2025 10:27:45 -0300 Subject: [PATCH 1/2] chore: add jira board reference and screenshots to the pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 58 +++++++++++++++++++++++++++++++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1cbcf307c..a0878d3de 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,12 +5,24 @@ Make sure the base repository is `rootstrap/react-native-template` BEFORE creati ❌❌❌ --> +#### Jira board reference: + +- [Jira_Card_Name](https://rootstrap.atlassian.net/browse/ABC-123) + +--- + ## What does this do? +--- + ## Why did you do this? + +- [ ] Tested on iOS +- [ ] Tested on Android +- [ ] Tested on a small device +- [ ] Tested on a real device +- [ ] Tested all flows related with this PR changes +- [ ] Tested accessibility +- [ ] Added tests + +--- + +#### Notes: + + + +--- + +## **Screenshots / Previews** + + + + + +🧑‍🎨 **Figma Design**: + + + +📱 **Android**: + + + +📱 **iOS**: + + From 63deb46c852415e08cacf981998a24935cf585b0 Mon Sep 17 00:00:00 2001 From: Fernanda Toledo Date: Fri, 16 May 2025 11:00:08 -0300 Subject: [PATCH 2/2] fix: matching string when modifying pr template on project creation --- cli/setup-project.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/setup-project.js b/cli/setup-project.js index 74bc36582..8d644ec11 100755 --- a/cli/setup-project.js +++ b/cli/setup-project.js @@ -130,7 +130,7 @@ const updateGitHubWorkflows = (projectName) => { fileName: '.github/PULL_REQUEST_TEMPLATE.md', replacements: [ { - searchValue: /^[\s\S]*?(?=## What does this do\?)/, + searchValue: /^[\s\S]*?(?=#### Jira board reference:)/, replaceValue: '', }, ],