Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Commit 76042ae

Browse files
roottoolclaude
andauthored
fix(ci): add missing dependency-review job to CI workflow (#53)
* fix(ci): add missing dependency-review job to CI workflow The wc-dependency-review.yml reusable workflow was defined but never invoked from ci.yml, causing dependency review to be silently skipped. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(ci): remove unnecessary pull-requests permission from dependency-review Remove comment-summary-in-pr feature and the pull-requests: write permission it required. The dependency-review-action only needs contents: read without the comment feature. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * style: Trim line * style: Format --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent a393f5f commit 76042ae

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@ jobs:
7070
secrets:
7171
CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}"
7272

73+
dependency-review:
74+
needs: [setup]
75+
if: ${{ needs.setup.outputs.dependencies == 'true' && github.event_name == 'pull_request' }}
76+
uses: ./.github/workflows/wc-dependency-review.yml
77+
7378
export-validation:
7479
needs: [setup, lint-format, type-check, test]
7580
if: always() && !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled')
@@ -79,7 +84,15 @@ jobs:
7984
name: Status Check
8085
runs-on: ubuntu-slim
8186
timeout-minutes: 1
82-
needs: [setup, lint-format, type-check, test, export-validation]
87+
needs:
88+
[
89+
setup,
90+
lint-format,
91+
type-check,
92+
test,
93+
export-validation,
94+
dependency-review,
95+
]
8396
if: always() && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled'))
8497
steps:
8598
- run: exit 1

.github/workflows/wc-dependency-review.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ on: workflow_call
55

66
permissions:
77
contents: read
8-
pull-requests: write
98

109
defaults:
1110
run:
@@ -27,4 +26,3 @@ jobs:
2726
with:
2827
deny-licenses: GPL-2.0, GPL-3.0
2928
fail-on-severity: moderate
30-
comment-summary-in-pr: always

0 commit comments

Comments
 (0)